Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add miner mocks #226

Merged
merged 2 commits into from
May 5, 2021
Merged

Add miner mocks #226

merged 2 commits into from
May 5, 2021

Conversation

TheTeaParty
Copy link
Contributor

@TheTeaParty TheTeaParty commented May 1, 2021 •
edited

Closes #225 This PR depends on #222

Adds miner/mocks directory, with generated mocks with mockery.

@TheTeaParty TheTeaParty requested review from platsko and removed request for platsko May 1, 2021 21:25
@TheTeaParty TheTeaParty closed this May 1, 2021
@TheTeaParty TheTeaParty reopened this May 1, 2021
@TheTeaParty TheTeaParty marked this pull request as draft May 1, 2021 22:40
@guruhubb guruhubb requested review from platsko and Sriep May 2, 2021 15:13
@TheTeaParty TheTeaParty force-pushed the feat/miner-mocks branch 2 times, most recently from c588536 to 2685570 Compare May 2, 2021 23:56
@TheTeaParty TheTeaParty closed this May 2, 2021
@TheTeaParty TheTeaParty reopened this May 3, 2021
@TheTeaParty TheTeaParty marked this pull request as ready for review May 3, 2021 00:06
Sriep
Sriep reviewed May 5, 2021
View reviewed changes
Copy link
Contributor

@Sriep Sriep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The *.go changes are tagged as autogenerated files. Should maintaining these and other autogenerated mock files be added to the continuous integration process; probably with a GitHub action?

@Sriep Sriep merged commit e9b5343 into master May 5, 2021
@Sriep Sriep deleted the feat/miner-mocks branch May 5, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sriep Sriep Sriep approved these changes

@platsko platsko Awaiting requested review from platsko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add miner mocks
2 participants
@TheTeaParty @Sriep