Remove fileID from fileMetaHash #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## sprint-july-1 #1114 +/- ##
================================================
Coverage ? 26.51%
================================================
Files ? 80
Lines ? 9078
Branches ? 0
================================================
Hits ? 2407
Misses ? 6362
Partials ? 309
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Manual system tests [cancelled] with the following config
|
|
Manual system tests [failure] with the following config
|
Hitenjain14
requested review from
peterlimg,
dabasov,
guruhubb and
cnlangzi
as code owners
|
Manual system tests [failure] with the following config
|
|
Manual system tests [cancelled] with the following config
|
|
Manual system tests [failure] with the following config
|
dabasov
added a commit
that referenced
this pull request
Jul 11, 2023
* Add path in thumbnail hash (#1098) * get path from changes * pass rootRef in apply changes * add logs * fix deletechange * fix multi op and copy * fix delete root dir * fix delete root change * fix lint issue * cleanup and stats change * rename func to processMove * calculate object tree in ref path * rmv return from deleteChange * revert changes * move to filestore changes * check prevRoot * add logs and condition * check filestore * requested changes * validate nil proof * add move and copy dir tests * add logs * use path to add child * fix error log * fix add child * add proof log * add more logs * change read log * log objectPath * add commit logs * commit thumbnail first * add missing param * add missing param * add path in the thumbnail hash * add allocID and validation root index * use write * add condn in count query * rmv thumbnail_filename * log wm * cleanup * add rollback wm check * allow empty allocation root * fix tests * check path in upload * fix check * empty commit --------- Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> Co-authored-by: Yury <yuderbasov@gmail.com> * Dep/update (#1153) * dependencies update * dependencies update * Remove fileID from fileMetaHash (#1114) * rmv fileID from hash calc * Trigger Build * adding false commit to restart systemtests * add path in fileMetaHash * empty commit --------- Co-authored-by: Yury <yuderbasov@gmail.com> Co-authored-by: shahnawaz-creator <117025384+shahnawaz-creator@users.noreply.github.com> Co-authored-by: boddumanohar <b.manu199@gmail.com> Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> * optimize image (#1148) Co-authored-by: boddumanohar <b.manu199@gmail.com> * once for logger init * Update challenge timing submission (#1140) * update challenge timing submission * fix createdAt in challenge timing table --------- Co-authored-by: Yury <yuderbasov@gmail.com> * Fix blobber size (#1163) * Do not redeem readmarkers for free reads (#1166) * do not redeem readmarkers for free reads * fix unit tests, remove readmarker handling from download method * updated dependencies --------- Co-authored-by: Hitenjain14 <57557631+Hitenjain14@users.noreply.github.com> Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> Co-authored-by: shahnawaz-creator <117025384+shahnawaz-creator@users.noreply.github.com> Co-authored-by: boddumanohar <b.manu199@gmail.com> Co-authored-by: Manali-Jain-squareops <86873900+Manali-Jain-squareops@users.noreply.github.com> Co-authored-by: Jayash Satolia <73050737+Jayashsatolia403@users.noreply.github.com> Co-authored-by: stewartie4 <ryanstewart456@gmail.com> Co-authored-by: Dinmukhammed <52813950+din-mukhammed@users.noreply.github.com>
Kishan-Dhakan
added a commit
that referenced
this pull request
Jul 16, 2023
* Add path in thumbnail hash (#1098) * get path from changes * pass rootRef in apply changes * add logs * fix deletechange * fix multi op and copy * fix delete root dir * fix delete root change * fix lint issue * cleanup and stats change * rename func to processMove * calculate object tree in ref path * rmv return from deleteChange * revert changes * move to filestore changes * check prevRoot * add logs and condition * check filestore * requested changes * validate nil proof * add move and copy dir tests * add logs * use path to add child * fix error log * fix add child * add proof log * add more logs * change read log * log objectPath * add commit logs * commit thumbnail first * add missing param * add missing param * add path in the thumbnail hash * add allocID and validation root index * use write * add condn in count query * rmv thumbnail_filename * log wm * cleanup * add rollback wm check * allow empty allocation root * fix tests * check path in upload * fix check * empty commit --------- Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> Co-authored-by: Yury <yuderbasov@gmail.com> * Dep/update (#1153) * dependencies update * dependencies update * Remove fileID from fileMetaHash (#1114) * rmv fileID from hash calc * Trigger Build * adding false commit to restart systemtests * add path in fileMetaHash * empty commit --------- Co-authored-by: Yury <yuderbasov@gmail.com> Co-authored-by: shahnawaz-creator <117025384+shahnawaz-creator@users.noreply.github.com> Co-authored-by: boddumanohar <b.manu199@gmail.com> Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> * optimize image (#1148) Co-authored-by: boddumanohar <b.manu199@gmail.com> * once for logger init * Update challenge timing submission (#1140) * update challenge timing submission * fix createdAt in challenge timing table --------- Co-authored-by: Yury <yuderbasov@gmail.com> * Fix blobber size (#1163) * Do not redeem readmarkers for free reads (#1166) * do not redeem readmarkers for free reads * fix unit tests, remove readmarker handling from download method * once for logger init (#1156) * once for logger init * init logging the same way we do in 0chain * init logging the same way we do in 0chain * Hotfix/map concurrent write (#1158) * once for logger init * wider locking window * Hotfix/remove custom nonce (#1141) * removed custom nonce managing logic * fixed logging * updated gosdk * uncommented previous nonce logic * uncommented previous nonce logic * uncommented previous nonce logic * uncommented previous nonce logic * Use single file to avoid maintaining multiple version of same file (#1160) * Use single file to avoid maintaining multiple version of same file * Fix config path * Remove variable * Update path variable for blobber service --------- Co-authored-by: Yury <yuderbasov@gmail.com> * fix consume quota lock (#1173) * Fix rm and wm timestamp (#1162) * once for logger init * init logging the same way we do in 0chain * init logging the same way we do in 0chain * add lastChallengeTime log * empty commit * refactor timestamp check in markers * Add diff txn for move to filestore * return if duplicate --------- Co-authored-by: dabasov <yuderbasov@gmail.com> * fixed gitactions fix issue * remove printing private key in logs (#1161) Co-authored-by: Yury <yuderbasov@gmail.com> * Fix concurrent upload issue (#1174) * Fix concurrent upload issue * Fix concurrent upload issue * Fix/concurrent upload issue (#1175) * Fix concurrent upload issue * Fix concurrent upload issue * Fix concurrent upload issue * Fix concurrent upload issue --------- Co-authored-by: Hitenjain14 <57557631+Hitenjain14@users.noreply.github.com> Co-authored-by: Yury <yuderbasov@gmail.com> Co-authored-by: shahnawaz-creator <117025384+shahnawaz-creator@users.noreply.github.com> Co-authored-by: boddumanohar <b.manu199@gmail.com> Co-authored-by: Manali-Jain-squareops <86873900+Manali-Jain-squareops@users.noreply.github.com> Co-authored-by: Jayash Satolia <73050737+Jayashsatolia403@users.noreply.github.com> Co-authored-by: stewartie4 <ryanstewart456@gmail.com> Co-authored-by: Dinmukhammed <52813950+din-mukhammed@users.noreply.github.com> Co-authored-by: Laxmi Prasad Oli <olilaxmiprasad@gmail.com> Co-authored-by: root <root@helm.cluster.local>
Manali-Jain-squareops
added a commit
that referenced
this pull request
Jul 19, 2023
* Add path in thumbnail hash (#1098) * get path from changes * pass rootRef in apply changes * add logs * fix deletechange * fix multi op and copy * fix delete root dir * fix delete root change * fix lint issue * cleanup and stats change * rename func to processMove * calculate object tree in ref path * rmv return from deleteChange * revert changes * move to filestore changes * check prevRoot * add logs and condition * check filestore * requested changes * validate nil proof * add move and copy dir tests * add logs * use path to add child * fix error log * fix add child * add proof log * add more logs * change read log * log objectPath * add commit logs * commit thumbnail first * add missing param * add missing param * add path in the thumbnail hash * add allocID and validation root index * use write * add condn in count query * rmv thumbnail_filename * log wm * cleanup * add rollback wm check * allow empty allocation root * fix tests * check path in upload * fix check * empty commit --------- Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> Co-authored-by: Yury <yuderbasov@gmail.com> * Dep/update (#1153) * dependencies update * dependencies update * Remove fileID from fileMetaHash (#1114) * rmv fileID from hash calc * Trigger Build * adding false commit to restart systemtests * add path in fileMetaHash * empty commit --------- Co-authored-by: Yury <yuderbasov@gmail.com> Co-authored-by: shahnawaz-creator <117025384+shahnawaz-creator@users.noreply.github.com> Co-authored-by: boddumanohar <b.manu199@gmail.com> Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> * optimize image (#1148) Co-authored-by: boddumanohar <b.manu199@gmail.com> * once for logger init * Update challenge timing submission (#1140) * update challenge timing submission * fix createdAt in challenge timing table --------- Co-authored-by: Yury <yuderbasov@gmail.com> * Fix blobber size (#1163) * build base blobber optimization * fixed indentation * fix * fix * fix * Do not redeem readmarkers for free reads (#1166) * do not redeem readmarkers for free reads * fix unit tests, remove readmarker handling from download method * added docker ignore * added docker ignore - testing * once for logger init (#1156) * once for logger init * init logging the same way we do in 0chain * init logging the same way we do in 0chain * Hotfix/map concurrent write (#1158) * once for logger init * wider locking window * Hotfix/remove custom nonce (#1141) * removed custom nonce managing logic * fixed logging * updated gosdk * uncommented previous nonce logic * uncommented previous nonce logic * uncommented previous nonce logic * uncommented previous nonce logic * Use single file to avoid maintaining multiple version of same file (#1160) * Use single file to avoid maintaining multiple version of same file * Fix config path * Remove variable * Update path variable for blobber service --------- Co-authored-by: Yury <yuderbasov@gmail.com> * fix consume quota lock (#1173) * Fix rm and wm timestamp (#1162) * once for logger init * init logging the same way we do in 0chain * init logging the same way we do in 0chain * add lastChallengeTime log * empty commit * refactor timestamp check in markers * Add diff txn for move to filestore * return if duplicate --------- Co-authored-by: dabasov <yuderbasov@gmail.com> * fixed gitactions fix issue * remove printing private key in logs (#1161) Co-authored-by: Yury <yuderbasov@gmail.com> * Fix concurrent upload issue (#1174) * Fix concurrent upload issue * Fix concurrent upload issue * Fix/concurrent upload issue (#1175) * Fix concurrent upload issue * Fix concurrent upload issue * Fix concurrent upload issue * Fix concurrent upload issue --------- Co-authored-by: Hitenjain14 <57557631+Hitenjain14@users.noreply.github.com> Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> Co-authored-by: Yury <yuderbasov@gmail.com> Co-authored-by: shahnawaz-creator <117025384+shahnawaz-creator@users.noreply.github.com> Co-authored-by: boddumanohar <b.manu199@gmail.com> Co-authored-by: Jayash Satolia <73050737+Jayashsatolia403@users.noreply.github.com> Co-authored-by: stewartie4 <ryanstewart456@gmail.com> Co-authored-by: Dinmukhammed <52813950+din-mukhammed@users.noreply.github.com> Co-authored-by: Laxmi Prasad Oli <olilaxmiprasad@gmail.com> Co-authored-by: root <root@helm.cluster.local>
dabasov
added a commit
that referenced
this pull request
Jul 22, 2023
* Add path in thumbnail hash (#1098) * get path from changes * pass rootRef in apply changes * add logs * fix deletechange * fix multi op and copy * fix delete root dir * fix delete root change * fix lint issue * cleanup and stats change * rename func to processMove * calculate object tree in ref path * rmv return from deleteChange * revert changes * move to filestore changes * check prevRoot * add logs and condition * check filestore * requested changes * validate nil proof * add move and copy dir tests * add logs * use path to add child * fix error log * fix add child * add proof log * add more logs * change read log * log objectPath * add commit logs * commit thumbnail first * add missing param * add missing param * add path in the thumbnail hash * add allocID and validation root index * use write * add condn in count query * rmv thumbnail_filename * log wm * cleanup * add rollback wm check * allow empty allocation root * fix tests * check path in upload * fix check * empty commit --------- Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> Co-authored-by: Yury <yuderbasov@gmail.com> * Dep/update (#1153) * dependencies update * dependencies update * Remove fileID from fileMetaHash (#1114) * rmv fileID from hash calc * Trigger Build * adding false commit to restart systemtests * add path in fileMetaHash * empty commit --------- Co-authored-by: Yury <yuderbasov@gmail.com> Co-authored-by: shahnawaz-creator <117025384+shahnawaz-creator@users.noreply.github.com> Co-authored-by: boddumanohar <b.manu199@gmail.com> Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> * optimize image (#1148) Co-authored-by: boddumanohar <b.manu199@gmail.com> * once for logger init * Update challenge timing submission (#1140) * update challenge timing submission * fix createdAt in challenge timing table --------- Co-authored-by: Yury <yuderbasov@gmail.com> * Fix blobber size (#1163) * Do not redeem readmarkers for free reads (#1166) * do not redeem readmarkers for free reads * fix unit tests, remove readmarker handling from download method * updated dependencies * once for logger init (#1156) * once for logger init * init logging the same way we do in 0chain * init logging the same way we do in 0chain * Hotfix/map concurrent write (#1158) * once for logger init * wider locking window * Hotfix/remove custom nonce (#1141) * removed custom nonce managing logic * fixed logging * updated gosdk * uncommented previous nonce logic * uncommented previous nonce logic * uncommented previous nonce logic * uncommented previous nonce logic * Use single file to avoid maintaining multiple version of same file (#1160) * Use single file to avoid maintaining multiple version of same file * Fix config path * Remove variable * Update path variable for blobber service --------- Co-authored-by: Yury <yuderbasov@gmail.com> * fix consume quota lock (#1173) * Fix rm and wm timestamp (#1162) * once for logger init * init logging the same way we do in 0chain * init logging the same way we do in 0chain * add lastChallengeTime log * empty commit * refactor timestamp check in markers * Add diff txn for move to filestore * return if duplicate --------- Co-authored-by: dabasov <yuderbasov@gmail.com> * fixed gitactions fix issue * remove printing private key in logs (#1161) Co-authored-by: Yury <yuderbasov@gmail.com> * Fix concurrent upload issue (#1174) * Fix concurrent upload issue * Fix concurrent upload issue * Update go.mod --------- Co-authored-by: Hitenjain14 <57557631+Hitenjain14@users.noreply.github.com> Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> Co-authored-by: shahnawaz-creator <117025384+shahnawaz-creator@users.noreply.github.com> Co-authored-by: boddumanohar <b.manu199@gmail.com> Co-authored-by: Manali-Jain-squareops <86873900+Manali-Jain-squareops@users.noreply.github.com> Co-authored-by: Jayash Satolia <73050737+Jayashsatolia403@users.noreply.github.com> Co-authored-by: stewartie4 <ryanstewart456@gmail.com> Co-authored-by: Dinmukhammed <52813950+din-mukhammed@users.noreply.github.com> Co-authored-by: Laxmi Prasad Oli <olilaxmiprasad@gmail.com> Co-authored-by: root <root@helm.cluster.local>
dabasov
added a commit
that referenced
this pull request
Jul 25, 2023
* Add path in thumbnail hash (#1098) * get path from changes * pass rootRef in apply changes * add logs * fix deletechange * fix multi op and copy * fix delete root dir * fix delete root change * fix lint issue * cleanup and stats change * rename func to processMove * calculate object tree in ref path * rmv return from deleteChange * revert changes * move to filestore changes * check prevRoot * add logs and condition * check filestore * requested changes * validate nil proof * add move and copy dir tests * add logs * use path to add child * fix error log * fix add child * add proof log * add more logs * change read log * log objectPath * add commit logs * commit thumbnail first * add missing param * add missing param * add path in the thumbnail hash * add allocID and validation root index * use write * add condn in count query * rmv thumbnail_filename * log wm * cleanup * add rollback wm check * allow empty allocation root * fix tests * check path in upload * fix check * empty commit --------- Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> Co-authored-by: Yury <yuderbasov@gmail.com> * Dep/update (#1153) * dependencies update * dependencies update * Remove fileID from fileMetaHash (#1114) * rmv fileID from hash calc * Trigger Build * adding false commit to restart systemtests * add path in fileMetaHash * empty commit --------- Co-authored-by: Yury <yuderbasov@gmail.com> Co-authored-by: shahnawaz-creator <117025384+shahnawaz-creator@users.noreply.github.com> Co-authored-by: boddumanohar <b.manu199@gmail.com> Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> * optimize image (#1148) Co-authored-by: boddumanohar <b.manu199@gmail.com> * once for logger init * Update challenge timing submission (#1140) * update challenge timing submission * fix createdAt in challenge timing table --------- Co-authored-by: Yury <yuderbasov@gmail.com> * Fix blobber size (#1163) * Do not redeem readmarkers for free reads (#1166) * do not redeem readmarkers for free reads * fix unit tests, remove readmarker handling from download method * once for logger init (#1156) * once for logger init * init logging the same way we do in 0chain * init logging the same way we do in 0chain * Hotfix/map concurrent write (#1158) * once for logger init * wider locking window * Hotfix/remove custom nonce (#1141) * removed custom nonce managing logic * fixed logging * updated gosdk * uncommented previous nonce logic * uncommented previous nonce logic * uncommented previous nonce logic * uncommented previous nonce logic * Use single file to avoid maintaining multiple version of same file (#1160) * Use single file to avoid maintaining multiple version of same file * Fix config path * Remove variable * Update path variable for blobber service --------- Co-authored-by: Yury <yuderbasov@gmail.com> * fix consume quota lock (#1173) * Fix rm and wm timestamp (#1162) * once for logger init * init logging the same way we do in 0chain * init logging the same way we do in 0chain * add lastChallengeTime log * empty commit * refactor timestamp check in markers * Add diff txn for move to filestore * return if duplicate --------- Co-authored-by: dabasov <yuderbasov@gmail.com> * fixed gitactions fix issue * remove printing private key in logs (#1161) Co-authored-by: Yury <yuderbasov@gmail.com> * Fix concurrent upload issue (#1174) * Fix concurrent upload issue * Fix concurrent upload issue * Fix/concurrent upload issue (#1175) * Fix concurrent upload issue * Fix concurrent upload issue * Fix concurrent upload issue * Fix concurrent upload issue * remove from docker compose files * remove reference to postgres-post * remove in conductor docker compose * remove useless changes --------- Co-authored-by: Hitenjain14 <57557631+Hitenjain14@users.noreply.github.com> Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> Co-authored-by: Yury <yuderbasov@gmail.com> Co-authored-by: shahnawaz-creator <117025384+shahnawaz-creator@users.noreply.github.com> Co-authored-by: boddumanohar <b.manu199@gmail.com> Co-authored-by: Manali-Jain-squareops <86873900+Manali-Jain-squareops@users.noreply.github.com> Co-authored-by: Jayash Satolia <73050737+Jayashsatolia403@users.noreply.github.com> Co-authored-by: stewartie4 <ryanstewart456@gmail.com> Co-authored-by: Dinmukhammed <52813950+din-mukhammed@users.noreply.github.com> Co-authored-by: Laxmi Prasad Oli <olilaxmiprasad@gmail.com> Co-authored-by: root <root@helm.cluster.local>
dabasov
added a commit
that referenced
this pull request
Jul 29, 2023
* Fix * Fix * Fix * Debug * Debug * Fix lint * Fix * Fix * False commit * Fix * Debug * False commit * Fix * Fix * Fix * Fix timestamp error * Added caching in GetOrCreate too * Fix * Fix typecast * Add path in thumbnail hash (#1098) * get path from changes * pass rootRef in apply changes * add logs * fix deletechange * fix multi op and copy * fix delete root dir * fix delete root change * fix lint issue * cleanup and stats change * rename func to processMove * calculate object tree in ref path * rmv return from deleteChange * revert changes * move to filestore changes * check prevRoot * add logs and condition * check filestore * requested changes * validate nil proof * add move and copy dir tests * add logs * use path to add child * fix error log * fix add child * add proof log * add more logs * change read log * log objectPath * add commit logs * commit thumbnail first * add missing param * add missing param * add path in the thumbnail hash * add allocID and validation root index * use write * add condn in count query * rmv thumbnail_filename * log wm * cleanup * add rollback wm check * allow empty allocation root * fix tests * check path in upload * fix check * empty commit --------- Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> Co-authored-by: Yury <yuderbasov@gmail.com> * Dep/update (#1153) * dependencies update * dependencies update * Remove fileID from fileMetaHash (#1114) * rmv fileID from hash calc * Trigger Build * adding false commit to restart systemtests * add path in fileMetaHash * empty commit --------- Co-authored-by: Yury <yuderbasov@gmail.com> Co-authored-by: shahnawaz-creator <117025384+shahnawaz-creator@users.noreply.github.com> Co-authored-by: boddumanohar <b.manu199@gmail.com> Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> * Fixed lints * Added ceil * optimize image (#1148) Co-authored-by: boddumanohar <b.manu199@gmail.com> * Fix * once for logger init * Update challenge timing submission (#1140) * update challenge timing submission * fix createdAt in challenge timing table --------- Co-authored-by: Yury <yuderbasov@gmail.com> * Fix blobber size (#1163) * cleaning up caching code * Do not redeem readmarkers for free reads (#1166) * do not redeem readmarkers for free reads * fix unit tests, remove readmarker handling from download method * once for logger init (#1156) * once for logger init * init logging the same way we do in 0chain * init logging the same way we do in 0chain * Hotfix/map concurrent write (#1158) * once for logger init * wider locking window * Hotfix/remove custom nonce (#1141) * removed custom nonce managing logic * fixed logging * updated gosdk * uncommented previous nonce logic * uncommented previous nonce logic * uncommented previous nonce logic * uncommented previous nonce logic * Use single file to avoid maintaining multiple version of same file (#1160) * Use single file to avoid maintaining multiple version of same file * Fix config path * Remove variable * Update path variable for blobber service --------- Co-authored-by: Yury <yuderbasov@gmail.com> * fix consume quota lock (#1173) * add sprint* branches in tests.yml * fixed merge problem * fixed merge problem * add logs in wm lock * fixed broken unit test * fix type assertion * fix nil pointer dereference * fix get alloc by id --------- Co-authored-by: Hitenjain14 <57557631+Hitenjain14@users.noreply.github.com> Co-authored-by: Kishan Dhakan <42718091+Kishan-Dhakan@users.noreply.github.com> Co-authored-by: Yury <yuderbasov@gmail.com> Co-authored-by: shahnawaz-creator <117025384+shahnawaz-creator@users.noreply.github.com> Co-authored-by: boddumanohar <b.manu199@gmail.com> Co-authored-by: Manali-Jain-squareops <86873900+Manali-Jain-squareops@users.noreply.github.com> Co-authored-by: stewartie4 <ryanstewart456@gmail.com> Co-authored-by: Dinmukhammed <52813950+din-mukhammed@users.noreply.github.com> Co-authored-by: Laxmi Prasad Oli <olilaxmiprasad@gmail.com> Co-authored-by: Hitenjain14 <hitenjain146@gmail.com> Co-authored-by: din-mukhammed <dimash.r53@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):