Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair Allocation Tests #731

Merged
merged 16 commits into from Jul 4, 2023
Merged

Repair Allocation Tests #731

merged 16 commits into from Jul 4, 2023

Conversation

Hitenjain14
Copy link
Member

@Hitenjain14 Hitenjain14 commented Jun 21, 2023 •
edited

@Hitenjain14 Hitenjain14 mentioned this pull request Jun 21, 2023
Merged
3 tasks
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests replace-api-test
gosdk refactor/repair
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/fileMetaHash
authorizer staging
0box staging
0dns staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped false
system-tests replace-api-test
gosdk refactor/repair
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/fileMetaHash
authorizer staging
0box staging
0dns staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped false
system-tests replace-api-test
gosdk refactor/repair
zboxcli fix/fileMetaHash
zwalletcli staging
0chain staging
blobber fix/fileMetaHash
authorizer staging
0box staging
0dns staging

@Hitenjain14 Hitenjain14 linked an issue Jun 22, 2023 that may be closed by this pull request
repair allocation system tests #117
Closed
stewartie4
stewartie4 approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@stewartie4 stewartie4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great, but we need CLI coverage too

stewartie4
stewartie4 suggested changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@stewartie4 stewartie4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve once CLI coverage has been added

@Kishan-Dhakan Kishan-Dhakan changed the base branch from master to sprint-july-1 July 4, 2023 17:59
@Kishan-Dhakan
Copy link
Contributor

Have to merge to sprint branch since 0chain/gosdk#1004 got merged. Added issue 0chain/gosdk#1004

@Kishan-Dhakan Kishan-Dhakan merged commit dfe6529 into sprint-july-1 Jul 4, 2023
5 of 9 checks passed
@Kishan-Dhakan Kishan-Dhakan deleted the replace-api-test branch July 4, 2023 18:14
@dabasov dabasov mentioned this pull request Jul 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewartie4 stewartie4 stewartie4 requested changes

@Kishan-Dhakan Kishan-Dhakan Kishan-Dhakan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

repair allocation system tests
4 participants
@Hitenjain14 @service-0chain @Kishan-Dhakan @stewartie4