Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/nonce issue #724

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Fix/nonce issue #724

merged 3 commits into from
Jun 14, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Jun 13, 2022

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@cnlangzi cnlangzi mentioned this pull request Jun 13, 2022
3 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2022

Codecov Report

Merging #724 (145e764) into staging (ee6faea) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           staging     #724      +/-   ##
===========================================
+ Coverage    24.18%   24.19%   +0.01%     
===========================================
  Files           69       69              
  Lines         7907     7899       -8     
===========================================
- Hits          1912     1911       -1     
+ Misses        5710     5704       -6     
+ Partials       285      284       -1     
Flag Coverage 螖
Unit-Tests 24.19% <酶> (+0.01%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...ode/go/0chain.net/blobbercore/allocation/entity.go 0.00% <0.00%> (酶)
...et/blobbercore/handler/object_operation_handler.go 32.48% <0.00%> (+0.03%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ee6faea...145e764. Read the comment docs.

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/nonce_issue
zboxcli staging
zwalletcli staging
0chain staging
blobber fix/nonce_issue
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/nonce_issue
zboxcli fix/nonce_issue
zwalletcli fix/nonce_issue
0chain staging
blobber fix/nonce_issue
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/nonce_issue
zboxcli fix/nonce_issue
zwalletcli fix/nonce_issue
0chain exp/lost_transaction
blobber fix/nonce_issue
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/nonce_issue
zboxcli fix/nonce_issue
zwalletcli fix/nonce_issue
0chain fix/nonce_issue
blobber fix/nonce_issue
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Collaborator

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/nonce_issue
zboxcli fix/nonce_issue
zwalletcli fix/nonce_issue
0chain fix/nonce_issue
blobber fix/nonce_issue
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi requested a review from peterlimg June 14, 2022 01:18
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cnlangzi cnlangzi merged commit 8fd5fab into staging Jun 14, 2022
@cnlangzi cnlangzi deleted the fix/nonce_issue branch June 14, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants