Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zcncore): set nonce on submitting #143

Merged
merged 2 commits into from
Jun 14, 2022
Merged

fix(zcncore): set nonce on submitting #143

merged 2 commits into from
Jun 14, 2022

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Jun 13, 2022

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/nonce_issue
zboxcli fix/nonce_issue
zwalletcli fix/nonce_issue
0chain staging
blobber fix/nonce_issue
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/nonce_issue
zboxcli fix/nonce_issue
zwalletcli fix/nonce_issue
0chain exp/lost_transaction
blobber fix/nonce_issue
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/nonce_issue
zboxcli fix/nonce_issue
zwalletcli fix/nonce_issue
0chain fix/nonce_issue
blobber fix/nonce_issue
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix/nonce_issue
zboxcli fix/nonce_issue
zwalletcli fix/nonce_issue
0chain fix/nonce_issue
blobber fix/nonce_issue
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@cnlangzi cnlangzi requested a review from peterlimg June 14, 2022 01:18
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cnlangzi cnlangzi merged commit 250431d into staging Jun 14, 2022
@cnlangzi cnlangzi deleted the fix/nonce_issue branch June 14, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants