-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
add health check sc for validators #2128 #951
Conversation
Codecov Report
馃摚 This organization is not using Codecov鈥檚 GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## staging #951 +/- ##
===========================================
- Coverage 26.53% 26.44% -0.10%
===========================================
Files 76 76
Lines 7638 7665 +27
===========================================
Hits 2027 2027
- Misses 5345 5372 +27
Partials 266 266
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
func ValidatorHealthCheck() (*transaction.Transaction, error) { | ||
|
||
if valConfig.Configuration.Capacity == 0 { | ||
// setValidatorHealthCheckError(ErrValidatorHasRemoved) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove dead code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we will need to wait for the validator_health_check
SC implemented on 0chain, before merging this one.
I have been working on it , just wanted to know if we can emit validator health check in DbHealthCheck or new table has to be created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Manual system tests [success] with the following config
|
Changes
Added common method for both validator and blobber to send health check transaction.
Added healthcheck frequency to config/0chain_validator
Created new method type for VALIDATOR_HEALTH_CHECK in blobbercore/transaction/entity
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):