validator health check sc

[Hitenjain14]

Changes

Created a sc function validator_health_check - issue #2128

Tests

Tasks to complete before merging PR:

• Ensure system tests are passing. If not Run them manually to check for any regressions 📋
• Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
• Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

• blobber: validator health check worker
• gosdk:
• system_test:
• zboxcli:
• zwalletcli:
• Other: ...

[codecov-commenter]

Codecov Report

Merging #2138 (8e0eee5) into staging (7d19e73) will increase coverage by 0.11%.
The diff coverage is 42.30%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           staging    #2138      +/-   ##
===========================================
+ Coverage    27.02%   27.13%   +0.11%     
===========================================
  Files          374      374              
  Lines        61976    62010      +34     
===========================================
+ Hits         16747    16825      +78     
+ Misses       43261    43203      -58     
- Partials      1968     1982      +14     

Flag	Coverage Δ
Unit-Tests	27.13% <42.30%> (+0.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...go/0chain.net/smartcontract/dbs/event/validator.go	24.61% <0.00%> (-2.74%)	⬇️
...e/go/0chain.net/smartcontract/storagesc/handler.go	2.23% <0.00%> (-0.02%)	⬇️
...de/go/0chain.net/smartcontract/storagesc/models.go	55.28% <ø> (ø)
code/go/0chain.net/smartcontract/storagesc/sc.go	40.10% <0.00%> (-0.44%)	⬇️
...o/0chain.net/smartcontract/storagesc/models_gen.go	35.69% <36.84%> (+1.29%)	⬆️
...go/0chain.net/smartcontract/storagesc/validator.go	27.98% <56.25%> (+6.47%)	⬆️
...n.net/smartcontract/storagesc/validator_eventdb.go	36.14% <67.85%> (+8.36%)	⬆️
...ain.net/smartcontract/storagesc/config_settigns.go	54.76% <0.00%> (ø)
...de/go/0chain.net/smartcontract/vestingsc/config.go	58.42% <0.00%> (+1.57%)	⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[peterlimg]

Looks good to me 👍 , please add unit tests to make sure the new added SC work as expected.

[boddumanohar]

@Hitenjain14 please see if you could also add isActive query parameter to /validators endpoint
#2127

[Hitenjain14]

@Hitenjain14 please see if you could also add isActive query parameter to /validators endpoint #2127

Will look into it, do we have any unit tests for blobber_health_check ?

[peterlimg]

LGTM

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	master
gosdk	NOT OVERRIDDEN
zboxcli	fix-rounding-off-for-balance
zwalletcli	fix-rounding-off-for-balance
0chain	staging
blobber	staging
authorizer	staging
0box	fix-rounding-off-for-balance
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

[service-0chain]

Manual system tests [cancelled] with the following config

config	value
tests skipped	FALSE
system-tests	master
gosdk	NOT OVERRIDDEN
zboxcli	fix-rounding-off-for-balance
zwalletcli	fix-rounding-off-for-balance
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

[service-0chain]

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	master
gosdk	NOT OVERRIDDEN
zboxcli	fix-rounding-off-for-balance
zwalletcli	fix-rounding-off-for-balance
0chain	staging
blobber	staging
authorizer	staging
0box	staging
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging