Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writemarker renamed to allocation root #975

Merged
merged 1 commit into from
Mar 8, 2023
Merged

writemarker renamed to allocation root #975

merged 1 commit into from
Mar 8, 2023

Conversation

Hitenjain14
Copy link
Member

Changes

As suggested by @lpoli , Writemarker in Ref struct is renamed to AllocationRoot #957

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • gosdk:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

peterlimg
peterlimg approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hitenjain14 Hitenjain14 linked an issue Mar 7, 2023 that may be closed by this pull request
Allocation root or WriteMarker should be removed from Ref struct. #957
Closed
@dabasov dabasov merged commit 3fecdee into staging Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

@dabasov dabasov Awaiting requested review from dabasov dabasov is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

@cnlangzi cnlangzi Awaiting requested review from cnlangzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allocation root or WriteMarker should be removed from Ref struct.
3 participants
@Hitenjain14 @peterlimg @dabasov