Update gosdk to support txn fee #979

Kishan-Dhakan · 2023-03-03T19:33:21Z

Changes

Fixes

Tests

Tasks to complete before merging PR:

Ensure system tests are passing. If not Run them manually to check for any regressions 📋
Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

0chain:
gosdk:
system_test:
zboxcli:
zwalletcli:
Other: ...

codecov-commenter · 2023-03-03T21:27:40Z

Codecov Report

Merging #979 (e9f3d7a) into staging (47eecad) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           staging     #979   +/-   ##
========================================
  Coverage    27.73%   27.73%           
========================================
  Files           77       77           
  Lines         8091     8091           
========================================
  Hits          2244     2244           
  Misses        5556     5556           
  Partials       291      291

Flag	Coverage Δ
Unit-Tests	`27.73% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

service-0chain · 2023-03-03T21:51:53Z

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	chain-fee
gosdk	NOT OVERRIDDEN
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

service-0chain · 2023-03-04T07:45:50Z

Manual system tests [cancelled] with the following config

config	value
tests skipped	FALSE
system-tests	chain-fee
gosdk	NOT OVERRIDDEN
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

* staging: Modify/fmt leaf hash calculation (#912) Validator health (#994)

service-0chain · 2023-03-13T19:59:41Z

Manual system tests [cancelled] with the following config

config	value
tests skipped	ABILITY TO SKIP TESTS IS DISABLED. SKIP_TESTS OPTION IGNORED.
system-tests	chain-fee
gosdk	NOT OVERRIDDEN
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

service-0chain · 2023-03-15T15:56:59Z

Manual system tests [failure] with the following config

config	value
tests skipped	ABILITY TO SKIP TESTS IS DISABLED. SKIP_TESTS OPTION IGNORED.
system-tests	chain-fee-remove-excess-faucet
gosdk	NOT OVERRIDDEN
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

service-0chain · 2023-03-15T19:53:27Z

Manual system tests [failure] with the following config

config	value
tests skipped	ABILITY TO SKIP TESTS IS DISABLED. SKIP_TESTS OPTION IGNORED.
system-tests	chain-fee
gosdk	NOT OVERRIDDEN
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

service-0chain · 2023-03-18T00:13:33Z

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	chain-fee
gosdk	NOT OVERRIDDEN
zboxcli	chain-fee
zwalletcli	chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

service-0chain · 2023-03-18T01:22:19Z

Manual system tests [failure] with the following config

config	value
tests skipped	false
system-tests	chain-fee
gosdk	chain-fee
zboxcli	chain-fee
zwalletcli	chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

service-0chain · 2023-03-18T03:22:44Z

Manual system tests [failure] with the following config

config	value
tests skipped	false
system-tests	chain-fee
gosdk	chain-fee
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

service-0chain · 2023-03-18T04:38:17Z

Manual system tests [cancelled] with the following config

config	value
tests skipped	false
system-tests	chain-fee
gosdk	chain-fee
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

boddumanohar · 2023-03-23T21:00:01Z

will be addressed by: #1008

peterlimg · 2023-03-24T02:25:40Z

Before gosdk PR 0chain/gosdk#623 is merged, we still need this PR to support blobber with txn fee.

* staging: Fix: typos (#950) Setup Swagger (#876)

* staging: Chore update deps (#1008)

service-0chain · 2023-03-31T06:25:18Z

Manual system tests [cancelled] with the following config

config	value
tests skipped	FALSE
system-tests	chain-fee
gosdk	chain-fee
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

service-0chain · 2023-03-31T12:08:22Z

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	chain-fee
gosdk	chain-fee
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

service-0chain · 2023-04-01T01:03:36Z

Manual system tests [success] with the following config

config	value
tests skipped	FALSE
system-tests	chain-fee
gosdk	chain-fee
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	master
0proxy	staging
0search	staging

service-0chain · 2023-04-12T23:40:02Z

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	chain-fee
gosdk	chain-fee
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

service-0chain · 2023-04-13T14:27:11Z

Manual system tests [cancelled] with the following config

config	value
tests skipped	FALSE
system-tests	chain-fee
gosdk	chain-fee
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

service-0chain · 2023-04-17T00:48:55Z

Manual system tests [success] with the following config

config	value
tests skipped	FALSE
system-tests	chain-fee
gosdk	chain-fee
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0block	staging
0dns	staging
explorer	staging
0proxy	staging
0search	staging

service-0chain · 2023-04-17T04:57:05Z

Manual system tests [failure] with the following config

config	value
tests skipped	FALSE
system-tests	chain-fee
gosdk	chain-fee
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee-v2
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0dns	staging

service-0chain · 2023-04-17T05:32:29Z

Manual system tests [cancelled] with the following config

config	value
tests skipped	FALSE
system-tests	chain-fee
gosdk	chain-fee
zboxcli	chain-fee
zwalletcli	feat/chain-fee
0chain	chain-fee-v2
blobber	chain-fee
authorizer	chain-fee
0box	chain-fee
0dns	staging

peterlimg

LGTM

Update gosdk to support txn fee

4f7af17

Kishan-Dhakan requested review from peterlimg, dabasov, guruhubb and cnlangzi as code owners March 3, 2023 19:33

Kishan-Dhakan added 5 commits March 4, 2023 01:20

resolve conflicts

f569cff

update gosdk to chain-fee latest

94a9bd2

update common package

d5cf1b2

revert common package

af55027

go mod

03b5c0d

Kishan-Dhakan and others added 5 commits March 4, 2023 13:46

chainfee gosdk

241e982

fix ToToken assignment

9080c75

Merge branch 'staging' into chain-fee

dbf8141

Update gosdk

bd726c7

Merge branch 'staging' into chain-fee

7d69eba

* staging: Modify/fmt leaf hash calculation (#912) Validator health (#994)

peterlimg force-pushed the chain-fee branch from b05f6c2 to 7d69eba Compare March 13, 2023 03:31

Merge branch 'staging' into chain-fee

6cefdc3

update with staging

427aade

boddumanohar closed this Mar 23, 2023

peterlimg reopened this Mar 24, 2023

peterlimg added 3 commits March 24, 2023 10:26

Merge branch 'staging' into chain-fee

cd183aa

* staging: Fix: typos (#950) Setup Swagger (#876)

Update gosdk@chain-fee

74b3a67

Merge branch 'staging' into chain-fee

e9f3d7a

* staging: Chore update deps (#1008)

Merge branch 'staging' into chain-fee

09feec1

Update gosdk

55baaf0

peterlimg force-pushed the chain-fee branch from acce076 to 55baaf0 Compare April 13, 2023 12:01

peterlimg approved these changes Apr 17, 2023

View reviewed changes

peterlimg merged commit ba3a56f into staging Apr 17, 2023
4 of 5 checks passed

peterlimg deleted the chain-fee branch April 17, 2023 05:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update gosdk to support txn fee #979

Update gosdk to support txn fee #979

Kishan-Dhakan commented Mar 3, 2023

codecov-commenter commented Mar 3, 2023 •

edited

service-0chain commented Mar 3, 2023

service-0chain commented Mar 4, 2023

service-0chain commented Mar 13, 2023

service-0chain commented Mar 15, 2023

service-0chain commented Mar 15, 2023

service-0chain commented Mar 18, 2023

service-0chain commented Mar 18, 2023

service-0chain commented Mar 18, 2023

service-0chain commented Mar 18, 2023

boddumanohar commented Mar 23, 2023

peterlimg commented Mar 24, 2023

service-0chain commented Mar 31, 2023

service-0chain commented Mar 31, 2023

service-0chain commented Apr 1, 2023

service-0chain commented Apr 12, 2023

service-0chain commented Apr 13, 2023

service-0chain commented Apr 17, 2023

service-0chain commented Apr 17, 2023

service-0chain commented Apr 17, 2023

peterlimg left a comment

Update gosdk to support txn fee #979

Update gosdk to support txn fee #979

Conversation

Kishan-Dhakan commented Mar 3, 2023

Changes

Fixes

Tests

Associated PRs (Link as appropriate):

codecov-commenter commented Mar 3, 2023 • edited

Codecov Report

service-0chain commented Mar 3, 2023

service-0chain commented Mar 4, 2023

service-0chain commented Mar 13, 2023

service-0chain commented Mar 15, 2023

service-0chain commented Mar 15, 2023

service-0chain commented Mar 18, 2023

service-0chain commented Mar 18, 2023

service-0chain commented Mar 18, 2023

service-0chain commented Mar 18, 2023

boddumanohar commented Mar 23, 2023

peterlimg commented Mar 24, 2023

service-0chain commented Mar 31, 2023

service-0chain commented Mar 31, 2023

service-0chain commented Apr 1, 2023

service-0chain commented Apr 12, 2023

service-0chain commented Apr 13, 2023

service-0chain commented Apr 17, 2023

service-0chain commented Apr 17, 2023

service-0chain commented Apr 17, 2023

peterlimg left a comment

Choose a reason for hiding this comment

codecov-commenter commented Mar 3, 2023 •

edited