Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/exposed GetAllocation/GetFileMeta/CreateDir/Rename/Delete in win sdk #814

Merged
merged 8 commits into from Mar 6, 2023
Merged

Feat/exposed GetAllocation/GetFileMeta/CreateDir/Rename/Delete in win sdk #814

merged 8 commits into from Mar 6, 2023

Conversation

cnlangzi
Copy link
Contributor

@cnlangzi cnlangzi commented Mar 2, 2023 •
edited

Changes

  • exposed GetAllocation, GetFileMeta, CreateDir, Rename, Delete in win sdk.

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@cnlangzi cnlangzi changed the title Feat/exposed get allocation and rename in win Feat/exposed GetAllocation/GetFileMeta/CreateDir/Rename/Delete in win sdk Mar 2, 2023
@cnlangzi cnlangzi mentioned this pull request Mar 2, 2023
Closed
3 tasks
peterlimg
peterlimg approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@peterlimg peterlimg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cnlangzi cnlangzi merged commit 67d1fb6 into staging Mar 6, 2023
@cnlangzi cnlangzi deleted the feat/exposed_get_allocation_and_rename_in_win branch March 6, 2023 03:16
peterlimg added a commit that referenced this pull request Mar 10, 2023
@peterlimg
Merge branch 'staging' into chain-fee
b2bd55e 
* staging:
  Use defined context (#837)
  Feature: add wrapper for "authorizer-health-check" smart contract call (#836)
  remove from wasm: createWallet, recoverWallet (#834)
  feat wasm: expose functions (#831)
  add file_id to FileStats response (#785)
  add mime_type , created_at, updated_at to getRemoteFileMap (#818)
  Feat/exposed GetAllocation/GetFileMeta/CreateDir/Rename/Delete in win sdk (#814)
  Fix dir create issue by checking name early (#821)
  feature: modified workflows (#820)
  updated macos self hosted runner. (#813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

@dabasov dabasov Awaiting requested review from dabasov dabasov is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cnlangzi @peterlimg