Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mime_type , created_at, updated_at to getRemoteFileMap #818

Merged
merged 4 commits into from Mar 6, 2023
Merged

add mime_type , created_at, updated_at to getRemoteFileMap #818

merged 4 commits into from Mar 6, 2023

Conversation

boddumanohar
Copy link
Contributor

@boddumanohar boddumanohar commented Mar 4, 2023 •
edited

Changes

fixes:

  • undefined value for allocation min lock
  • added mime_type , created_at, updated_at to sdk. getRemoteFileMap

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

dabasov
dabasov approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boddumanohar boddumanohar mentioned this pull request Mar 6, 2023
Merged
3 tasks
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk fix-responses
zboxcli zbox-list-all
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@dabasov dabasov merged commit d92b27b into staging Mar 6, 2023
1 check passed
@dabasov dabasov deleted the fix-responses branch March 6, 2023 20:32
@boddumanohar boddumanohar mentioned this pull request Mar 6, 2023
Closed
peterlimg added a commit that referenced this pull request Mar 10, 2023
@peterlimg
Merge branch 'staging' into chain-fee
b2bd55e 
* staging:
  Use defined context (#837)
  Feature: add wrapper for "authorizer-health-check" smart contract call (#836)
  remove from wasm: createWallet, recoverWallet (#834)
  feat wasm: expose functions (#831)
  add file_id to FileStats response (#785)
  add mime_type , created_at, updated_at to getRemoteFileMap (#818)
  Feat/exposed GetAllocation/GetFileMeta/CreateDir/Rename/Delete in win sdk (#814)
  Fix dir create issue by checking name early (#821)
  feature: modified workflows (#820)
  updated macos self hosted runner. (#813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

@cnlangzi cnlangzi Awaiting requested review from cnlangzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boddumanohar @service-0chain @dabasov