Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feature): download from single blobber #868

Merged
merged 13 commits into from
May 15, 2023
Merged

(feature): download from single blobber #868

merged 13 commits into from
May 15, 2023

Conversation

boddumanohar
Copy link
Contributor

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@boddumanohar boddumanohar linked an issue Mar 28, 2023 that may be closed by this pull request
Download File from one blobber only 0chain/blobber#1014
Closed
@boddumanohar
Copy link
Contributor Author

@peterlimg @dabasov can you please this PR, thanks

peterlimg
peterlimg previously requested changes May 12, 2023
View reviewed changes
zboxcore/sdk/allocation.go Outdated Show resolved Hide resolved
zboxcore/sdk/allocation.go Outdated Show resolved Hide resolved
dabasov
dabasov approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boddumanohar boddumanohar merged commit 3f82dc7 into staging May 15, 2023
@boddumanohar boddumanohar deleted the download-from-single-blobber branch May 15, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

@cnlangzi cnlangzi Awaiting requested review from cnlangzi

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Download File from one blobber only
3 participants
@boddumanohar @dabasov @peterlimg