Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dns): check http status code on GetNetworkDetials #312

Merged
merged 2 commits into from
Oct 18, 2022
Merged

fix(dns): check http status code on GetNetworkDetials #312

merged 2 commits into from
Oct 18, 2022

Conversation

cnlangzi
Copy link
Contributor

Changes

Fixes

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@cnlangzi cnlangzi mentioned this pull request Oct 18, 2022
Merged
3 tasks
@cnlangzi cnlangzi merged commit 1a84c0c into staging Oct 18, 2022
@cnlangzi cnlangzi deleted the fix/throw_http_error_on_dns_query branch October 18, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg peterlimg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show raw/friendly error message if dns is down
2 participants
@cnlangzi @peterlimg