Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zbox sc-config allocation flag is removed #361

Conversation

SinanEkm
Copy link
Contributor

A brief description of the changes in this PR:
The allocation flag in the sc-config command is removed due to its being unnecessary.

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • 0chain:
  • blobber:
  • gosdk:
  • system_test:
  • zwalletcli:
  • Other: ...

@SinanEkm SinanEkm linked an issue Feb 23, 2023 that may be closed by this pull request
Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kishan-Dhakan Kishan-Dhakan merged commit b7476e9 into staging Feb 23, 2023
@Kishan-Dhakan Kishan-Dhakan deleted the 356-zbox-sc-config-works-even-if-required-flag-is-not-passed branch February 25, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zbox sc-config works even if required flag is not passed
2 participants