Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed stakepool lock/unlock interface #199

Merged
merged 9 commits into from
Dec 10, 2022
Merged

changed stakepool lock/unlock interface #199

merged 9 commits into from
Dec 10, 2022

Conversation

dabasov
Copy link
Member

@dabasov dabasov commented Nov 27, 2022

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 馃搵
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@dabasov dabasov self-assigned this Nov 27, 2022
@dabasov dabasov mentioned this pull request Nov 27, 2022
3 tasks
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/staking
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli fix/staking
0chain fix/staking
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

cmd/minersc.go Outdated Show resolved Hide resolved
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/staking
gosdk fix/staking
zboxcli staging
zwalletcli fix/staking
0chain fix/staking
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/staking
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli fix/staking
0chain fix/unstaking
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests fix/staking
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli fix/staking
0chain fix/unstaking
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@dabasov dabasov mentioned this pull request Dec 6, 2022
3 tasks
@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests fix/staking
gosdk NOT OVERRIDDEN
zboxcli staging
zwalletcli fix/staking
0chain fix/staking
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests fix/staking
gosdk fix/staking
zboxcli staging
zwalletcli fix/staking
0chain fix/staking
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests fix/staking
gosdk NOT OVERRIDDEN
zboxcli fix/staking
zwalletcli fix/staking
0chain fix/staking
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests fix/staking
gosdk NOT OVERRIDDEN
zboxcli fix/staking
zwalletcli fix/staking
0chain fix/staking
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Copy link
Contributor

@Kishan-Dhakan Kishan-Dhakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dabasov dabasov merged commit bd3194f into staging Dec 10, 2022
peterlimg added a commit that referenced this pull request Jan 27, 2023
* staging:
  upgrade GoSDK to v1.8.11
  fix: wrong gosdk version usage fixed
  changed stakepool lock/unlock interface (#199)
  fix: removed usage of local gosdk
  feature: added remove authorizer method
peterlimg added a commit that referenced this pull request Jan 27, 2023
* staging:
  upgrade GoSDK to v1.8.11
  fix: wrong gosdk version usage fixed
  changed stakepool lock/unlock interface (#199)
  fix: removed usage of local gosdk
  feature: added remove authorizer method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants