Fix/staking #333
Merged
Fix/staking #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manual system tests [failure] with the following config
|
Comment on lines
+250
to
-264
| _, _, err = sdk.StakePoolUnlock(providerType, providerID, zcncore.ConvertToValue(fee)) | ||
| // an error | ||
| if err != nil { | ||
| log.Fatalf("Failed to unlock tokens in stake pool: %v", err) | ||
| } | ||
|
|
||
| // can't unlock for now | ||
| if !unstake { | ||
| fmt.Println("tokens can't be unlocked due to opened offers") | ||
| fmt.Printf("the pool marked as releasing, wait and retry to succeed") | ||
| fmt.Printf("to reduce blobber commitments cancel or finalize allocations") | ||
| fmt.Println() | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
Is it okay to unlock at any time now?
Kishan-Dhakan
approved these changes
Dec 10, 2022
|
Manual system tests [success] with the following config
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A brief description of the changes in this PR:
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):
0chain: 0chain/0chain#1823
gosdk: 0chain/gosdk#662
system_test: 0chain/system_test#487
zwalletcli: 0chain/zwalletcli#199