Skip to content

Commit

Permalink
reimplement-idr-and-ida-using-the-radix-tree-support-storing-null-in-…
Browse files Browse the repository at this point in the history
…the-idr-checkpatch-fixes

WARNING: braces {} are not necessary for single statement blocks
torvalds#143: FILE: tools/testing/radix-tree/idr-test.c:88:
+	for (i = 0; i < 10; i++) {
+		assert(idr_alloc(&idr, NULL, 0, 0, GFP_KERNEL) == i);
+	}

WARNING: braces {} are not necessary for single statement blocks
torvalds#167: FILE: tools/testing/radix-tree/idr-test.c:112:
+	for (i = 1; i < 10; i++) {
+		assert(idr_alloc(&idr, NULL, 1, 0, GFP_KERNEL) == i);
+	}

total: 0 errors, 2 warnings, 159 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/reimplement-idr-and-ida-using-the-radix-tree-support-storing-null-in-the-idr.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Matthew Wilcox <mawilcox@microsoft.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  • Loading branch information
akpm00 authored and hnaz committed Dec 20, 2016
1 parent 4bace06 commit 21bedd7
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions tools/testing/radix-tree/idr-test.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,8 @@ void idr_null_test(void)
int i;
DEFINE_IDR(idr);

for (i = 0; i < 10; i++) {
for (i = 0; i < 10; i++)
assert(idr_alloc(&idr, NULL, 0, 0, GFP_KERNEL) == i);
}

assert(idr_replace(&idr, DUMMY_PTR, 3) == NULL);
assert(idr_replace(&idr, DUMMY_PTR, 4) == NULL);
Expand All @@ -109,9 +108,8 @@ void idr_null_test(void)
idr_destroy(&idr);
assert(idr_is_empty(&idr));

for (i = 1; i < 10; i++) {
for (i = 1; i < 10; i++)
assert(idr_alloc(&idr, NULL, 1, 0, GFP_KERNEL) == i);
}

idr_destroy(&idr);
}
Expand Down

0 comments on commit 21bedd7

Please sign in to comment.