Skip to content

Commit

Permalink
net: mdiobus: Introduce fwnode_mdiobus_register_phy()
Browse files Browse the repository at this point in the history
Introduce fwnode_mdiobus_register_phy() to register PHYs on the
mdiobus. From the compatible string, identify whether the PHY is
c45 and based on this create a PHY device instance which is
registered on the mdiobus.

Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com>
  • Loading branch information
calvinjolinux authored and intel-lab-lkp committed Sep 30, 2020
1 parent f782520 commit 6e5127a
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 0 deletions.
40 changes: 40 additions & 0 deletions drivers/net/phy/mdio_bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,46 @@ int mdiobus_unregister_device(struct mdio_device *mdiodev)
}
EXPORT_SYMBOL(mdiobus_unregister_device);

int fwnode_mdiobus_register_phy(struct mii_bus *bus,
struct fwnode_handle *child, u32 addr)
{
struct phy_device *phy;
bool is_c45;
const char *cp;
u32 phy_id;
int rc;

rc = fwnode_property_read_string(child, "compatible", &cp);
is_c45 = !(rc || strcmp(cp, "ethernet-phy-ieee802.3-c45"));

if (is_c45 || fwnode_get_phy_id(child, &phy_id))
phy = get_phy_device(bus, addr, is_c45);
else
phy = phy_device_create(bus, addr, phy_id, 0, NULL);
if (IS_ERR(phy))
return PTR_ERR(phy);

phy->irq = bus->irq[addr];

/* Associate the fwnode with the device structure so it
* can be looked up later.
*/
phy->mdio.dev.fwnode = child;

/* All data is now stored in the phy struct, so register it */
rc = phy_device_register(phy);
if (rc) {
phy_device_free(phy);
fwnode_handle_put(phy->mdio.dev.fwnode);
return rc;
}

dev_dbg(&bus->dev, "registered phy at address %i\n", addr);

return 0;
}
EXPORT_SYMBOL(fwnode_mdiobus_register_phy);

struct phy_device *mdiobus_get_phy(struct mii_bus *bus, int addr)
{
struct mdio_device *mdiodev = bus->mdio_map[addr];
Expand Down
2 changes: 2 additions & 0 deletions include/linux/mdio.h
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,8 @@ int mdiobus_register_device(struct mdio_device *mdiodev);
int mdiobus_unregister_device(struct mdio_device *mdiodev);
bool mdiobus_is_registered_device(struct mii_bus *bus, int addr);
struct phy_device *mdiobus_get_phy(struct mii_bus *bus, int addr);
int fwnode_mdiobus_register_phy(struct mii_bus *bus,
struct fwnode_handle *child, u32 addr);

/**
* mdio_module_driver() - Helper macro for registering mdio drivers
Expand Down

0 comments on commit 6e5127a

Please sign in to comment.