fix: Change fragmentRefs output to use typename string literal rather than $tada.ref
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitten
changed the title
fragmentRefs output to use typename string literal rather than $tada.ref
🦋 Changeset detectedLatest commit: 04d004b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
JoviDeCroock
approved these changes
Mar 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #110
Summary
This replaces the
$tada.refvalue on the$tada.fragmentRefsrecord for masked fragments with a string literal of the typename of the given fragment, further increasing readability and further decreasing the chance of fragment name conflicts.Using the symbol as a value flag was redundant, since the entire object is already a value on a symbol property (
$tada.fragmentRefs) and this change will further increase readability of output types.It also happens to fix #110, since Remix's
JsonifyObjectdoes not filter keys but only values.Set of changes
$tada.refvalue with fragment typename