Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix preprocessed introspection being cut off by TS #152

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Mar 20, 2024

Follow-up to #150

Summary

TypeScript seems to have hard limits on either:

  • how many property types are evaluated
  • how many property types on recursive type aliases are evaluated
  • how many properties may be printed

None of these limits seem to be cirumventable. Especially the limit on type evaluation is pretty aggressive and replaces the type with the errorType, making it hard to figure out how to expand type evaluation and printing after the limit.

Instead, this PR now splits printing up by type to temporarily work around this.

Set of changes

  • Split printing of introspection types up to circumvent hard limit

Copy link

changeset-bot bot commented Mar 21, 2024

⚠️ No Changeset found

Latest commit: 4b9f8e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kitten kitten enabled auto-merge (squash) March 21, 2024 00:00
@kitten kitten merged commit 3b1ef6d into main Mar 21, 2024
1 check passed
@kitten kitten deleted the fix/introspection-limit branch March 21, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant