Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace TS-based with string-based preprocessed introspection output #154

Merged
merged 7 commits into from
Mar 21, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Mar 21, 2024

Follow-up to #150
Follow-up to #152

Summary

This removes the TypeScript-based introspection outputs in favour of string-based introspection type outputs.

The problem with the former is, while the code will be useful for outputting types later on, for introspections it's simply too slow to run in GraphQLSP.

Set of changes

  • Put introspection code into internal/src/introspection
  • Rewrite introspection output with string-based logic
  • Add tests

Copy link

changeset-bot bot commented Mar 21, 2024

⚠️ No Changeset found

Latest commit: fdfc2ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kitten kitten marked this pull request as ready for review March 21, 2024 11:49
@kitten kitten changed the title refactor: Replace TS-based with strng-based preprocessed introspection output refactor: Replace TS-based with string-based preprocessed introspection output Mar 21, 2024
@kitten kitten merged commit 6cc65b6 into main Mar 21, 2024
2 checks passed
@kitten kitten deleted the refactor/tsless-introspection-output branch March 21, 2024 12:04
@kitten kitten added this to the Are We Fast Yet? milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants