Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add gql.tada/ts-plugin alias #62

Merged
merged 6 commits into from
Jun 26, 2024
Merged

feat: Add gql.tada/ts-plugin alias #62

merged 6 commits into from
Jun 26, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Feb 21, 2024

Dependent on microsoft/TypeScript#57266
Resolves #75

Summary

We're waiting for TypeScript to support sub-paths for tsserver plugins to ease the installation instructions back down to a single package and avoid having to explain the different between @0no-co/graphqlsp and gql.tada to people.

This would turn gql.tada into a standalone entrypoint package for its experience.

Set of changes

  • Add gql.tada/ts-plugin alias

Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: 0e44b3b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten force-pushed the main branch 3 times, most recently from 0a251d0 to fefde0e Compare March 26, 2024 17:37
@kitten kitten force-pushed the main branch 2 times, most recently from 2dde208 to 06e6488 Compare April 4, 2024 09:13
@kitten kitten force-pushed the main branch 2 times, most recently from 92d094c to 81e2ed3 Compare April 25, 2024 14:53
@kitten kitten marked this pull request as ready for review April 26, 2024 01:35
@kitten
Copy link
Member Author

kitten commented Apr 26, 2024

Opening as ready since TypeScript 5.5 was announced and a beta (5.5.0) is ready. Fix is part of this release: microsoft/TypeScript@ef091bf

We could consider renaming this to gql.tada/ts-plugin instead of gql.tada/lsp though.

Another note is that we may want to update the init command. We can also add a check for doctor against the installed typescript version (<5.5 wouldn't work with this alias of course and we can detect that)

Docs wouldn't be updated until at least 5.5 is stable. Even then we may need a note for this, but I've already been considering adding a recommendation to run gql.tada doctor as another step to the "Installation" guide.

@kitten kitten changed the title feat: Add gql.tada/lsp alias feat: Add gql.tada/ts-plugin alias Apr 26, 2024
@kitten kitten merged commit 3afc304 into main Jun 26, 2024
1 check passed
@kitten kitten deleted the lsp-alias branch June 26, 2024 13:59
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Re-expose the GraphQLSP TS plugin at gql.tada/ts-plugin
2 participants