Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support set asset folder type #89

Merged
merged 12 commits into from
Jan 6, 2024
Merged

Conversation

peterxcli
Copy link
Contributor

move pasted image into images folder, then the image can show image in the built post

Screenshot 2023-12-20 at 2 15 51 AM

image

@peterxcli
Copy link
Contributor Author

@0x-jerry Please help me to review. Thx.

@0x-jerry
Copy link
Owner

0x-jerry commented Dec 20, 2023

@peterxcli Thanks for your contribution! Previously, I implemented this function for Hexo post asset folder, not for Global asset folder. So I think we may need an option, maybe hexo.pasteFolderType to specify the asset folder type, and the default value should be post to be compatible with the existing version.

A workaround is to disable the past image shortcut of this extension and use vscode-paste-image instead.

If you want to disable past image shortcut, here is an example: #45 (comment)

@peterxcli
Copy link
Contributor Author

@0x-jerry Thanks for your opinion. I have adopted your idea, please review it again.

@0x-jerry 0x-jerry self-requested a review December 20, 2023 13:39
@0x-jerry 0x-jerry changed the title fix: move pasted image into images folder, then the image can show image in the built post feat: support set asset folder type Jan 6, 2024
package.json Outdated Show resolved Hide resolved
src/commands/pasteImage.ts Outdated Show resolved Hide resolved
src/commands/pasteImage.ts Outdated Show resolved Hide resolved
@0x-jerry 0x-jerry merged commit 1fd1e39 into 0x-jerry:main Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants