Fix st_mode when using default values #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st_mode may be empty on e.g. on Inherit the Earth demo dmg root st_mode ends up being 0 on root which results in I/O error down the line when listing root directory. According to TN we need to fill st_mode, st_uid and st_gid with sane values ourselves in this case.
Closed
|
Thanks for adding this and thanks for bringing it up originally! I'll see if hfsfuse can support some of the weirder things that the macOS driver does for these kinds of files around UID substitution/permissions too now that I know about them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
st_mode may be empty on e.g. on Inherit the Earth demo dmg root st_mode ends up being 0 on root which results in I/O error down the line when listing root directory.
According to TN we need to fill st_mode, st_uid and st_gid with sane values ourselves in this case.