Skip to content

Commit

Permalink
Compiler config TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
0x19 committed Aug 28, 2023
1 parent 01bb1be commit 00f10f2
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions compiler_config.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,19 +58,20 @@ func NewCompilerConfigFromJSON(compilerVersion string, entrySourceName string, c
toReturn := &CompilerConfig{
EntrySourceName: entrySourceName,
CompilerVersion: compilerVersion,
Arguments: []string{
"--standard-json", // Output to stdout.
},
JsonConfig: config,
Arguments: []string{"--standard-json"},
JsonConfig: config,
}

if _, err := toReturn.SanitizeArguments(toReturn.Arguments); err != nil {
return nil, err
}

/* if err := toReturn.Validate(); err != nil {
return nil, err
} */
/*
TODO: Validation at this point for the JSON config is not done.
It's assumed that the caller has already validated the JSON config.
if err := toReturn.Validate(); err != nil {
return nil, err
} */

return toReturn, nil
}
Expand Down

0 comments on commit 00f10f2

Please sign in to comment.