Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple code formatting best practices, and some bug fixes combined #114

Merged
merged 7 commits into from
Aug 14, 2022
Merged

Multiple code formatting best practices, and some bug fixes combined #114

merged 7 commits into from
Aug 14, 2022

Commits on Aug 10, 2022

  1. Removed trailing spaces using VSCode + Trailing Spaces addon

    @BZanten
    BZanten committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    69854ee View commit details
    Browse the repository at this point in the history

  2. Updated Smart quotes “ and ” with straight quotes "

    @BZanten
    BZanten committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    9a3be3f View commit details
    Browse the repository at this point in the history

  3. Updated codeformatting via PSScriptAnalyzer: Invoke-Formatter -Script… 

    …Definition (Get-Content .\Invoke-HardeningKitty.ps1 -Raw) -Settings CodeFormattingOTBS
    @BZanten
    BZanten committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    4183fa8 View commit details
    Browse the repository at this point in the history

  4. Bugfix replaced = with -eq

    @BZanten
    BZanten committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    d6cc3aa View commit details
    Browse the repository at this point in the history

  5. Replaced Invoke-Expression with PS splatting to solve PSScriptAnalyze… 

    …r warning regarding PSAvoidUsingInvokeExpression
    @BZanten
    BZanten committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    1a98bc9 View commit details
    Browse the repository at this point in the history

  6. Resolved all instances of PSAvoidUsingPositionalParameters by adding … 

    …the parameter names.

BugFixed the call to Out-IniFile by removing the additional unused parameter
    @BZanten
    BZanten committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    f5714c7 View commit details
    Browse the repository at this point in the history

  7. Switch types in Functions advanced parameters have a value of $False … 

    …by default, and should not be set to $False during declaration. Also bugfixed the .IsPresent usage (because being present doesn't mean it is true or false).

See https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/about/about_functions_advanced_parameters
    @BZanten
    BZanten committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    a548bfa View commit details
    Browse the repository at this point in the history