Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Update node-emoji #8

Closed
wants to merge 1 commit into from
Closed

Conversation

joelschou
Copy link

@joelschou joelschou commented Aug 9, 2018

Gatsby uses yurnalist in its CLI tools, but yurnalist uses an old version node-emoji which is missing quite a few really great ones, such as 🤷‍♂️. I can't use the newer node-emoji in my Gatsby-powered site, because yarn is too smart.

@0x80
Copy link
Owner

0x80 commented Dec 13, 2018

@joelschou Sorry for not responding! Apparently I wasn't watching my own repo and didn't get any notification of your PR 🤦‍♂️

I have just upgraded all code and dependencies to match the master branch from yarn, so your PR should not be necessary anymore. I will release yurnalist 0.3.0 with the changes.

@0x80 0x80 closed this Dec 13, 2018
@joelschou
Copy link
Author

Thanks!

@0x80
Copy link
Owner

0x80 commented Dec 13, 2018

@joelschou FYI I decided to make it 1.0.0. And then I upgraded all dependencies to latest which resulted in 1.1.0 😄

@joelschou
Copy link
Author

Versioning is the worst!

@0x80
Copy link
Owner

0x80 commented Dec 13, 2018

@joelschou I messed up something in the release so I unpublished the new versions for now. Not sure what happened yet...

@0x80
Copy link
Owner

0x80 commented Dec 13, 2018

@joelschou all set now. Don't know how I messed it up. I unpublished 1.0.0 and 1.1.0 and because NPM didn't allow me to publish 1.0.0 again it became 1.0.1 😅

@0x80
Copy link
Owner

0x80 commented Dec 13, 2018

Damn it 😞 The problem still persisted. Locally everything is fine testing the build, but somehow after publishing the paths are messed up and the require call throws. I will have a look at it later with a fresh mind.

Sorry for the noise.

@0x80 0x80 reopened this Dec 13, 2018
@0x80
Copy link
Owner

0x80 commented Dec 14, 2018

@joelschou I blindly copied the npmignore contents from the yarn repo which excluded the dist folder since yarn uses a different approach to publishing new versions. This messed up the module on publish.

I could not re-publish 1.0.0 because it was already un-published (as was 1.0.1), so the latest version is now 1.0.2.

@0x80 0x80 closed this Dec 14, 2018
@0x80
Copy link
Owner

0x80 commented Dec 14, 2018

Next time I'm doing a pre-release first, as I should have 😄

@joelschou
Copy link
Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants