Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yurnalist 0.2.1 uses an awfully old node-emoji, can gatsby-cli do something different, please? #8835

Closed
joelschou opened this issue Oct 5, 2018 · 10 comments
Labels
status: awaiting author response Additional information has been requested from the author status: needs more info Needs triaging and reproducible examples or more information to be resolved

Comments

@joelschou
Copy link

Description

I'm using Gatsby for a work project. gatsby-cli has yurnalist 0.2.1 as a dependency, which in turn has node-emoji 1.0.4. That particular version is really, really old. I've submitted a PR on yurnalist in hopes they'll update. It appears to be borderline abandoned, so I'm hoping Gatsby can do something different to accommodate.

Steps to reproduce

const emoji = require( 'node-emoji' );
console.log( emoji.get( ':shrug:' ) );

Expected result

$ 🤷

Actual result

$ :shrug:

Environment

  System:
    OS: macOS High Sierra 10.13.6
    CPU: x64 Intel(R) Core(TM) i7-6920HQ CPU @ 2.90GHz
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 10.9.0 - ~/.nvm/versions/node/v10.9.0/bin/node
    Yarn: 1.10.1 - /usr/local/bin/yarn
    npm: 6.2.0 - ~/.nvm/versions/node/v10.9.0/bin/npm
  Browsers:
    Chrome: 69.0.3497.100
    Safari: 12.0
  npmPackages:
    gatsby: 2.0.18 => 2.0.18
    gatsby-plugin-catch-links: 2.0.3 => 2.0.3
    gatsby-plugin-postcss-sass: 1.0.22 => 1.0.22
    gatsby-plugin-react-helmet: 3.0.0 => 3.0.0
    gatsby-plugin-sass: 2.0.1 => 2.0.1
    gatsby-remark-autolink-headers: 2.0.6 => 2.0.6
    gatsby-source-filesystem: 2.0.1 => 2.0.1
    gatsby-transformer-json: 2.1.4 => 2.1.4
    gatsby-transformer-remark: 2.1.6 => 2.1.6
  npmGlobalPackages:
    gatsby-cli: 2.4.2
@DSchau
Copy link
Contributor

DSchau commented Oct 5, 2018

@joelschou just to provide some context, what exactly are you running that requires emoji? It seems like this would be a build process thing, rather than something in your site?

@DSchau DSchau added status: needs more info Needs triaging and reproducible examples or more information to be resolved status: awaiting author response Additional information has been requested from the author labels Oct 5, 2018
@joelschou
Copy link
Author

This is a really, really minor thing, but I'm having some fun. See, I have a little plugin for getting content into Gatsby. I am using emoji to make the console logs more enjoyable:

const emoji = require( 'node-emoji' );
...
try {
    ...
} catch ( err ) {
    console.log( `${ emoji.get( ':shrug:' ) }  No named file at ${ namedPath } or readme at ${ readmePath } == no content to parse for ${ item }.` );
}

I've added the newest version of node-emoji to my dependencies, I have this in my yarn.lock:

gatsby-cli@^2.4.2:
  version "2.4.2"
  ...
  dependencies:
    ...
    yurnalist "^0.2.1"

yurnalist@^0.2.1:
  version "0.2.1"
  ...
  dependencies:
    ...
    node-emoji "^1.0.4"
    ...

I could fairly easily work around this by publishing a modified yurnalist to our internal NPM server, but thought Gatsby would like to know this super important emoji library is at the mercy of one of your dependencies 😉

@joelschou
Copy link
Author

I just poked around a little bit in gatsby-cli and I'm not sure yurnalist is even needed.

@KyleAMathews
Copy link
Contributor

We could definitely move away from Yurnalist as we only use small sub-set of its functionality.

@gatsbot
Copy link

gatsbot bot commented Jan 20, 2019

Old issues will be closed after 30 days of inactivity. This issue has been quiet for 20 days and is being marked as stale. Reply here or add the label "not stale" to keep this issue open!

@gatsbot gatsbot bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jan 20, 2019
@joelschou
Copy link
Author

FWIW, yurnalist has been updated recently and has better support for newer emoji sets now 😄

@gatsbot
Copy link

gatsbot bot commented Feb 1, 2019

Hey again!

It’s been 30 since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

Thanks again for being part of the Gatsby community!

@gatsbot gatsbot bot closed this as completed Feb 1, 2019
@joelschou
Copy link
Author

@KyleAMathews The bot does a nice job, but this doesn't need to be closed.

@m-allanson m-allanson removed the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 1, 2019
@m-allanson
Copy link
Contributor

@joelschou the bot was a bit over-eager here, it's had some updates in the last few days that should prevent that in the future. That said, gatsby-cli is now using an updated version of yurnalist so I think it's ok to leave this closed?

@joelschou
Copy link
Author

Sounds good to me! 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting author response Additional information has been requested from the author status: needs more info Needs triaging and reproducible examples or more information to be resolved
Projects
None yet
Development

No branches or pull requests

4 participants