[signer, readme] cleanup signer + update e2e test instructions #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xBEEFCAF3
reviewed
May 2, 2023
Co-authored-by: Armin Sabouri <armin@team.casa>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signer: Some code cleanup. Sorry this PR isn't more organized. Still in hackathon mode 😄
wait_for_coordinatormethod for commands that expect one response from the coordinatorloggingsrc.utils.nostr_utilsmethods to read nsec and coordinator public keySignerCommandsenum for all the valid commands a signer can provideREADME: Update steps on how to start the signer. Right now the key and nonce seeds are required.
Tested this locally and executed the
new wallet,send pkandaddresscommands. Did not test signing, but I also didn't touch much of that code.