Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientGroupsBlock should not be case-sensitive #894

Closed
onovy opened this issue Feb 22, 2023 · 0 comments · Fixed by #913
Closed

clientGroupsBlock should not be case-sensitive #894

onovy opened this issue Feb 22, 2023 · 0 comments · Fixed by #913
Labels
🔨 enhancement New feature or request
Milestone

Comments

@onovy
Copy link

onovy commented Feb 22, 2023

client IDs in clientGroupsBlock configuration block are matched case-sensitive now. Example:

$ host 192.168.1.1
1.1.168.192.in-addr.arpa domain name pointer UpperCase.test.local

$ cat config.yaml
...
blocking:
  clientGroupsBlock:
    UpperCase.test.local: [ads] # this matches
    uppercase.test.local: [ads] # this doesn't match

DNS is by specs case-insensitive and thus Client ID match from PTR should be case-insensitive.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants