Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: client name in clientGroupsBlock should not be case-sensitive #913

Merged
merged 1 commit into from Mar 7, 2023

Conversation

0xERR0R
Copy link
Owner

@0xERR0R 0xERR0R commented Mar 7, 2023

closes #894

@0xERR0R 0xERR0R added the 🔨 enhancement New feature or request label Mar 7, 2023
@0xERR0R 0xERR0R added this to the 0.21 milestone Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (3315873) 92.88% compared to head (b079d27) 92.86%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #913      +/-   ##
===============================================
- Coverage        92.88%   92.86%   -0.02%     
===============================================
  Files               49       49              
  Lines             5368     5368              
===============================================
- Hits              4986     4985       -1     
- Misses             310      311       +1     
  Partials            72       72              
Impacted Files Coverage Δ
resolver/blocking_resolver.go 98.14% <100.00%> (ø)
util/common.go 97.41% <100.00%> (ø)
resolver/query_logging_resolver.go 95.62% <0.00%> (-2.92%) ⬇️
lists/list_cache.go 98.78% <0.00%> (+1.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0xERR0R 0xERR0R merged commit 120e32c into development Mar 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the client-name-not-case-sensitive branch March 7, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clientGroupsBlock should not be case-sensitive
2 participants