feat: reduce DNS response cache memory consumption #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
ThinkChaos
reviewed
Oct 10, 2023
Co-authored-by: ThinkChaos <ThinkChaos@users.noreply.github.com>
ThinkChaos
approved these changes
Oct 10, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, we store dns.Msg struct in the DNS response cache. In my tests, a typical response for example "A google.com" needs approx. 270 bytes. If we cache the binary representation (wire format), we'll need only 70 bytes.
This PR changes the result cache struct from dns.Msg to []byte. This avoids also copying of dns struct on one place.