Use forked packages

[marcello33]

In this PR, we replace some cosmossdk.io registry based packages with the ones used in our fork.
Also, we replace cosmos-sdk and cometBFT with our forked versions.
As a "side-effect" the code has been changed in some places to use our own code.

I made sure that:

• the project builds
• the unit tests for customized modules (x/auth, x/bank, crypto, x/gov) are green
• the CI can build the app with the updated dependencies

Notes

• Some packages have been replaced with the same tag on our fork, i.e. cosmossdk.io/api => github.com/0xPolygon/cosmos-sdk/api v0.7.2
• Some packages have been replaced with "latest" devel version of our fork, because we modified them (e.g. to remove the bech32 stuff) but we did not produce any new tag, i.e. cosmossdk.io/x/circuit => github.com/0xPolygon/cosmos-sdk/x/circuit v0.1.1-0.20240409091007-84d9b34a8681
• Some packages have been replaced with our own forked tags (this only applies to cosmos-sdk itself and cometBFT), i.e. github.com/cometbft/cometbft => github.com/0xPolygon/cometbft v0.1.0-beta and github.com/cosmos/cosmos-sdk => github.com/0xPolygon/cosmos-sdk v0.1.0-beta-polygon

If approved and merged, a new release will be created and used in heimdall-v2, where a subset of such replace directives will be added.

[github-actions]

@marcello33 your pull request is missing a changelog!

[pratikspatil024]

Everytime we have a new release, we will need to update this, right? Wondering if there's a different way this can be done.

[marcello33]

Yeah, not sure about alternatives

[sergio-mena]

Check my comment above about the relative path. It can be used during development. Then, when you release a version of the fork, you just need to remember to come here and set the official version

[sergio-mena]

Hmmm, actually, are you sure you need this line in particular. What breaks if you delete it?

[marcello33]

I'd need to double check this, but iirc, the following happens if I remove that replace.
While importing cosmos-sdk as a dependency in heimdall-v2 I get parsing go.mod module declares its path as "github.com/cosmos/cosmos-sdk" but was required as "github.com/0xPolygon/cosmos-sdk"

[marcello33]

Anyway using the relative path now, but I confirm that was the issue
Addressed here 1554aba

[sergio-mena]

The relative path is good, I think, since it removes the hassle of having to be changing it all the time while in heavy development.

But, I'm still intrigued by the error you're getting. For context, what motivated my comment initially was the fact of seeing that the very first version of CometBFT (when we forked from Tendermint Core) declares itself as github.com/tendermint/tendermint see here , and so, there is no require of tendermint/tendermint anywhere in that go.mod.

I also checked Celestia's fork, which is now a fork of CometBFT. Same situation.

So, since you declare your repo in the same way (module github.com/cosmos/cosmos-sdk), I thought you wouldn't need to include it in the require section.

Just to be clear, I'm only referring to the line this thread is attached to (the top level go.mod). For all other go.mod files, the relative path is the best approach.

[marcello33]

Thanks @sergio-mena
Just created the release, will re-check this while importing in heimdall-v2 and - in case - make the required change

[sergio-mena]

Resolved (AFAIAC) -- notice that @pratikspatil024 opened this

[pratikspatil024]

Any idea where this change in keys.pulsar.go and keys.pb.go came from?

[marcello33]

Any idea where this change in keys.pulsar.go and keys.pb.go came from?

Yes, @pratikspatil024. I updated a comment once in a proto definition and most probably forgot to run make proto-all.
Fortunately, it's just a comment.

[sergio-mena]

LGTM 👍