Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM-677: Fix log index issue on eth_getTransactionReceipt #1576

Conversation

goran-ethernal
Copy link
Contributor

@goran-ethernal goran-ethernal commented Jun 1, 2023

Description

eth_getTransactionReceipt did not return correct indexes of logs. For example, if we had a block with 2 transactions with 2 logs each, and if we want a receipt from the second transaction, the function would return log indexes 0, 1, instead of 2, 3, since there is a transaction in the block that had logs before the desired transaction.

This PR fixes the issue and adds new UT.

This is continuation of work from PR 1533.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal changed the title Fix log index issue on eth_getTransactionReceipt EVM-677: Fix log index issue on eth_getTransactionReceipt Jun 1, 2023
@goran-ethernal goran-ethernal self-assigned this Jun 1, 2023
@goran-ethernal goran-ethernal requested a review from a team June 1, 2023 07:06
@goran-ethernal goran-ethernal added the bug fix Functionality that fixes a bug label Jun 1, 2023
@goran-ethernal goran-ethernal marked this pull request as ready for review June 1, 2023 07:07
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsonrpc/eth_endpoint.go Outdated Show resolved Hide resolved
@goran-ethernal goran-ethernal merged commit de626d9 into develop Jun 1, 2023
6 of 7 checks passed
@goran-ethernal goran-ethernal deleted the EVM-677-Fix-log-index-issue-on-eth-getTransactionReceipt branch June 1, 2023 12:18
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants