Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC-191] Add governorAdmin flag #1728

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Jul 17, 2023

Description

Added a new flag to genesis command, called --governor-admin.

It specifies the address of an admin for governance contracts. Given admin can add new addresses to the list of proposers of new governance proposals, and can add new addresses to the list of executors of accepted proposals.

On genesis, and contract deployment, we will set the initial list of proposers and executors of governance proposals to the genesis validator set. Later, when the chain is live, specified governor admin, can add new addresses and remove old ones.

If governor admin address was not specified, zero address will be set as admin, and no new proposer and executor or governance proposals can be added later when chain is live (the genesis validator set will remain forever as possible proposers and executors).

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal changed the title Add governorAdmin flag [RFC-191] Add governorAdmin flag Jul 17, 2023
@goran-ethernal goran-ethernal self-assigned this Jul 17, 2023
@goran-ethernal goran-ethernal added the feature New update to Polygon Edge label Jul 17, 2023
@goran-ethernal goran-ethernal requested a review from a team July 17, 2023 10:27
@goran-ethernal goran-ethernal marked this pull request as ready for review July 17, 2023 10:28
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments to consider.

command/genesis/polybft_params.go Outdated Show resolved Hide resolved
consensus/polybft/polybft_config.go Outdated Show resolved Hide resolved
command/genesis/polybft_params.go Outdated Show resolved Hide resolved
command/genesis/genesis.go Show resolved Hide resolved
command/genesis/genesis.go Outdated Show resolved Hide resolved
@goran-ethernal goran-ethernal merged commit 633d0db into feat/on-chain-governance Jul 17, 2023
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2023
@goran-ethernal goran-ethernal deleted the add-governor-admin-flag branch July 17, 2023 11:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants