Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC-191]: EVM-759 - Don't use hardcoded addresses for governance contracts #1790

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Aug 8, 2023

Description

This PR introduces new fields to governanceConfig part of genesis.json:

  • childGovernorAddr - address of ChildGovernor contract on supernet.
  • childTimelockAddr - address of ChildTimelock contract on supernet.
  • networkParamsAddr - address of NetworkParams contract on supernet.
  • forkParamsAddr - address of ForkParams contract on supernet.

We need to add them to genesis.json because, on live chains, these contracts will be deployed on random addresses, so the user needs to manually change the genesis.json file to keep those addresses as well, so that edge client knows how to handle governance events.

If the chain is started a new on the release that introduces governance, these fields will be automatically updated in genesis.json since on genesis we deploy these contracts automatically on predefined addresses.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal added the feature New update to Polygon Edge label Aug 8, 2023
@goran-ethernal goran-ethernal self-assigned this Aug 8, 2023
@goran-ethernal goran-ethernal requested a review from a team August 8, 2023 07:57
@goran-ethernal goran-ethernal marked this pull request as ready for review August 8, 2023 07:57
@goran-ethernal goran-ethernal changed the title Don't use hardcoded addresses for governance contracts [RFC-191]: EVM-759 - Don't use hardcoded addresses for governance contracts Aug 8, 2023
Base automatically changed from EVM-760-Utilize-ForkParams-contract to feat/on-chain-governance August 8, 2023 13:35
@goran-ethernal goran-ethernal force-pushed the EVM-759-Dont-use-hardcoded-addresses-of-governance-contracts branch from 5b98bfe to 9d97f79 Compare August 8, 2023 13:41
@goran-ethernal goran-ethernal merged commit b24e383 into feat/on-chain-governance Aug 9, 2023
7 checks passed
@goran-ethernal goran-ethernal deleted the EVM-759-Dont-use-hardcoded-addresses-of-governance-contracts branch August 9, 2023 07:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants