[RFC-191]: EVM-759 - Don't use hardcoded addresses for governance contracts #1790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces new fields to
governanceConfig
part ofgenesis.json
:childGovernorAddr
- address ofChildGovernor
contract on supernet.childTimelockAddr
- address ofChildTimelock
contract on supernet.networkParamsAddr
- address ofNetworkParams
contract on supernet.forkParamsAddr
- address ofForkParams
contract on supernet.We need to add them to
genesis.json
because, on live chains, these contracts will be deployed on random addresses, so the user needs to manually change thegenesis.json
file to keep those addresses as well, so that edge client knows how to handle governance events.If the chain is started a new on the release that introduces governance, these fields will be automatically updated in
genesis.json
since on genesis we deploy these contracts automatically on predefined addresses.Changes include
Checklist
Testing