[Fix] Change default jsonrpc binding to all interfaces (0.0.0.0) #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeljkoBenovic
requested review from
zivkovicmilos,
lazartravica and
Kourin1996
as code owners
zivkovicmilos
added
don't merge
|
Adding a |
zivkovicmilos
approved these changes
Mar 3, 2022
Aleksao998
approved these changes
Mar 3, 2022
zivkovicmilos
added
bug fix
Kourin1996
approved these changes
Mar 4, 2022
zivkovicmilos
removed
the
don't merge
|
@ZeljkoBenovic |
|
Merged the Cobra CLI changes, changed default ip bindings and fixed few minor things with server cli command help output |
zivkovicmilos
approved these changes
Mar 8, 2022
* create struct for IPBindings * set additional param in ResolveAddr for default ip binding
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the default JSON PRC and Prometheus IP binding to all interfaces ( 0.0.0.0 ) instead of localhost/loopback ( 127.0.0.1 )
This makes much more sense when starting the chain with default settings as this APIs will usually be queried from remote hosts.
Fixed server command usage defaults. For example:
--max-outbound-peers int the client's max number of outbound peers allowed. Default: 8 (default -1)now displays:
--max-outbound-peers int the client's max number of outbound peers allowed. (default 8)Changes include
Checklist
Testing
Manual tests
Started the server with
--jsonrpc :10001and without--jsonrpcflag.Started the server with
--prometheus :5001flag.The JSON RPC API always binds to all interfaces and can be queried from remote host
The Prometheus API binds to all interfaces on defined port
Documentation update
Doc PR#70
Additional comments
Fixes EDGE-421