CLI refactor

[zivkovicmilos]

Description

This PR features a complete rewrite of the CLI module in Polygon Edge, the simplification of command additions and the pruning of several now useless packages:

• https://github.com/mitchellh/cli
• https://github.com/imdario/mergo

The new CLI implementation is based on Cobra

Changes include

• Bugfix (non-breaking change that solves an issue)
• Hotfix (change that solves an urgent issue, and requires immediate attention)
• New feature (non-breaking change that adds functionality)
• Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

• I have assigned this PR to myself
• I have added at least 1 reviewer
• I have added the relevant labels
• I have updated the official documentation
• I have added sufficient documentation in code

Testing

• I have tested this code with the official test suite
• I have tested this code manually

Manual tests

The changes have been tested mostly through the e2e test suite that we have baked in, but also by following the official documentation and checking out different command flows.

Documentation update

Relevant Docs PR

Additional comments

Fixes EDGE-44

CLI changes

The following flags have been renamed:

Command	Old flag	New flag
genesis	chainid	chain-id
server	grpc	grpc-address

Dropped commands

dev

The helpful dev command has been dropped for now, and it's reintroduction should be a part of a smaller task in the future.

New tasks

During the refactor of the CLI module, several places for improvement have been spotted.

Dropping the --seal concept from Polygon Edge

Explained in detail in E-394

Adding unit tests

Explained in detail in E-397

Generating CLI docs

Explained in detail in E-398

[dbrajovic]

Apart from the global params variable in each params.go file (which we should discuss), everything else seems well encapsulated. 👍

[Aleksao998]

LGTM!

[lazartravica]

Tests pass, common commands confirmed working, backwards compatibility is also 👌

I have one issue while testing, I cannot start server with default values for arguments:

$ go run main.go server
failed to parse addr 'http://127.0.0.1:8545': address http://127.0.0.1:8545: too many colons in address
exit status 1

Please take a look at this and address my comments in the code review, thanks for the extra effort on this PR 🙏

[zivkovicmilos]

@lazartravica

Resolved the problem with the default address, turns out it was just the default value set incorrectly to include the protocol name:

61e0d02

[lazartravica]

@zivkovicmilos thanks for fixing the comments, and sorry for bugging you about the dev & dummy consensus - i’ve misunderstood your additional comments section :)

merging this