-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docker setup for local env #747
Added docker setup for local env #747
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Codecov Report
@@ Coverage Diff @@
## develop #747 +/- ##
===========================================
+ Coverage 52.48% 52.50% +0.01%
===========================================
Files 130 130
Lines 17069 17069
===========================================
+ Hits 8959 8962 +3
+ Misses 7466 7464 -2
+ Partials 644 643 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hey @begmaroman, Thank you for your first contribution to the Edge codebase 🙏 Please follow the instructions by the CLA bot, so the contributor list is maintained correctly: |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission! This feature will help provide another reliable quick-start method for testing/sandboxing. 👍 Provided a few change requests out there to help better improve the experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🥇
Left a few comments.
The only thing I would improve here to remove the need to build the binary for every container, as it takes a lot of time to actually start everything.
It would be much better, if we could build the polygon-edge
binary just one time, and then use that binary for all containers.
NWM, it's running great, but running it on WSL has some issues and it takes forever to build ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added docker and docker-compose setup to run the service locally.
Changes include
Checklist
Testing