Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker setup for local env #747

Merged
merged 9 commits into from
Sep 23, 2022

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Sep 21, 2022

Description

Added docker and docker-compose setup to run the service locally.

$ make run-local
...
$ make stop-local

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@github-actions
Copy link

github-actions bot commented Sep 21, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@begmaroman begmaroman self-assigned this Sep 21, 2022
@begmaroman begmaroman added the feature New update to Polygon Edge label Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #747 (86534ad) into develop (7ada10f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #747      +/-   ##
===========================================
+ Coverage    52.48%   52.50%   +0.01%     
===========================================
  Files          130      130              
  Lines        17069    17069              
===========================================
+ Hits          8959     8962       +3     
+ Misses        7466     7464       -2     
+ Partials       644      643       -1     
Impacted Files Coverage Δ
tests/testing.go 69.33% <0.00%> (ø)
chain/chain_bindata.go 32.31% <0.00%> (ø)
network/e2e_testing.go 63.89% <0.00%> (ø)
secrets/local/local.go 75.70% <0.00%> (ø)
consensus/ibft/fork/helper.go 81.81% <0.00%> (ø)
network/server_discovery.go 75.79% <0.00%> (+1.91%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zivkovicmilos
Copy link
Contributor

Hey @begmaroman,

Thank you for your first contribution to the Edge codebase 🙏
I've added our DevOps wizards @ZeljkoBenovic and @epikichi to also give feedback.

Please follow the instructions by the CLA bot, so the contributor list is maintained correctly:
#747 (comment)

docker/local/polygon-edge.sh Outdated Show resolved Hide resolved
docker/local/polygon-edge.sh Outdated Show resolved Hide resolved
@begmaroman
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@epikichi epikichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! This feature will help provide another reliable quick-start method for testing/sandboxing. 👍 Provided a few change requests out there to help better improve the experience.

docker/local/docker-compose.yml Outdated Show resolved Hide resolved
docker/local/docker-compose.yml Show resolved Hide resolved
docker/local/Dockerfile Show resolved Hide resolved
Copy link
Contributor

@ZeljkoBenovic ZeljkoBenovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🥇
Left a few comments.

The only thing I would improve here to remove the need to build the binary for every container, as it takes a lot of time to actually start everything.
It would be much better, if we could build the polygon-edge binary just one time, and then use that binary for all containers.

NWM, it's running great, but running it on WSL has some issues and it takes forever to build ...

docker/local/polygon-edge.sh Outdated Show resolved Hide resolved
docker/local/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begmaroman begmaroman merged commit 29177a3 into develop Sep 23, 2022
@begmaroman begmaroman deleted the feature/add-docker-setup-for-runnin-locally branch September 23, 2022 08:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants