Implemented state #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # state/batch.go # state/block.go # state/state.go
# Conflicts: # aggregator/aggregator.go # mocks/state.go # sequencer/sequencer.go # state/state.go
Mikelle
requested review from
arnaubennassar,
ARR552,
OBrezhniev,
tclemos and
ToniRamirezM
as code owners
ToniRamirezM
approved these changes
Nov 30, 2021
arnaubennassar
requested changes
Nov 30, 2021
Comment on lines
+48
to
+53
| // init db | ||
| var err error | ||
| err = db.RunMigrations(cfg) | ||
| if err != nil { | ||
| panic(err) | ||
| } |
There was a problem hiding this comment.
I think we should move this inside dbutils.StartPostgreSQL
There was a problem hiding this comment.
I would move it in another PR. If I move it in my PR, I will have to update every place, that is usingStartPostgreSQL function
arnaubennassar
approved these changes
Nov 30, 2021
zfy0701
pushed a commit
to sentioxyz/zkevm-node
that referenced
this pull request
Mar 5, 2024
…tion AggLayer integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Closes #15