Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix computeGasSendCall #221

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Fix computeGasSendCall #221

merged 4 commits into from
Jan 9, 2023

Conversation

ignasirv
Copy link
Contributor

@ignasirv ignasirv commented Jan 4, 2023 •
edited
Loading

Remove critical free inputs from:

  • computeGasSendCall
  • saveMem
    Fix free inputs from:
  • rotate.zkasm line 25
  • create-terminate-context.zkasm line 723
  • utils.zkasm (offsetUtil) line 856

@cla-bot cla-bot bot added the cla-signed label Jan 4, 2023
@ignasirv ignasirv force-pushed the hotfix/fix-free-input branch 6 times, most recently from ddd6e10 to 012dd26 Compare January 4, 2023 15:03
@ignasirv ignasirv marked this pull request as ready for review January 4, 2023 15:04
@ignasirv ignasirv marked this pull request as draft January 4, 2023 15:04
@ignasirv ignasirv marked this pull request as ready for review January 4, 2023 15:28
@ignasirv ignasirv force-pushed the hotfix/fix-free-input branch 2 times, most recently from 6e9d21c to e8f58fa Compare January 5, 2023 12:00
@ignasirv ignasirv marked this pull request as draft January 5, 2023 13:49
@ignasirv ignasirv force-pushed the hotfix/fix-free-input branch 4 times, most recently from bbca8db to 8f3c72c Compare January 5, 2023 15:59
@ignasirv ignasirv marked this pull request as ready for review January 9, 2023 14:45
@ignasirv ignasirv requested review from krlosMata, laisolizq and invocamanman and removed request for krlosMata and laisolizq January 9, 2023 14:45
krlosMata
krlosMata approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@krlosMata krlosMata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@ignasirv ignasirv merged commit bf6b6c5 into develop Jan 9, 2023
@ignasirv ignasirv deleted the hotfix/fix-free-input branch January 9, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlosMata krlosMata krlosMata approved these changes

@invocamanman invocamanman Awaiting requested review from invocamanman invocamanman is a code owner

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignasirv @krlosMata