Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename miden crate so that it matches the package name. #1270

Closed
hackaugusto opened this issue Mar 5, 2024 · 1 comment
Closed

Rename miden crate so that it matches the package name. #1270

hackaugusto opened this issue Mar 5, 2024 · 1 comment

Comments

@hackaugusto
Copy link
Contributor

At the moment the package miden-vm has the crate named miden. This means that after adding the miden-vm dependency to Cargo.toml (e.g. cargo add miden-vm), the code can't use miden_vm, but it has to use miden, because the package and the crate names don't match.

This issue is about renaming the crate so that it matches the package.
hackaugusto added a commit that referenced this issue Mar 5, 2024
@hackaugusto
miden-vm: match the crate with the package name. Fix #1270
2d44966
hackaugusto added a commit that referenced this issue Mar 5, 2024
@hackaugusto
miden-vm: match the crate with the package name. Fix #1270
975f1ad
hackaugusto added a commit that referenced this issue Mar 5, 2024
@hackaugusto
miden-vm: match the crate with the package name. Fix #1270 (#1271)
43c0d8c
@hackaugusto
Copy link
Contributor Author

implemented by #1271 and #1270

bobbinth pushed a commit that referenced this issue Apr 3, 2024
@hackaugusto @bobbinth
miden-vm: match the crate with the package name. Fix #1270 (#1271)
5013b94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hackaugusto