miden-vm: match the crate with the package name. Fix #1270 #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
approved these changes
Mar 5, 2024
|
oh - i guess we also need to update the executable code to import |
hackaugusto
force-pushed
the
hacka-rename-miden-crate-to-match-miden-vm-package-name
branch
from
2d44966
to
975f1ad
Compare
|
ah, oops, I only built the library. Updated the references to use |
hackaugusto
deleted the
hacka-rename-miden-crate-to-match-miden-vm-package-name
branch
|
Could you also update the changelog as I mentioned in #1271 (review). |
|
sorry, missed that |
This was referenced Mar 5, 2024
bobbinth
pushed a commit
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
As per the PR title. This makes the library crate name match the package name.
Checklist before requesting a review
nextaccording to naming convention.