Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlib: adds native hasher init procedure without padding #1313

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

hackaugusto
Copy link
Contributor

Describe your changes

Adds a procedure to initialize the stack with the native hasher initial state. This only covers the case without the need for padding.

Related to #1311

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth
Copy link
Contributor

Oh - one thing: could you also update the changelog?

@hackaugusto hackaugusto force-pushed the hacka-native-hasher-init-no-padding branch from 5bcac63 to 8c13d4f Compare April 25, 2024 21:45
@hackaugusto
Copy link
Contributor Author

Oh - one thing: could you also update the changelog?

Added.

Btw, IMO we should add a PR template, and have a checklist in there. I personally always forget to add the changelog to everything. (either that or a CI check)

@hackaugusto hackaugusto merged commit d282b01 into next Apr 25, 2024
15 checks passed
@hackaugusto hackaugusto deleted the hacka-native-hasher-init-no-padding branch April 25, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants