Span block decoding update #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grjte
suggested changes
May 22, 2022
There was a problem hiding this comment.
Looks good! I like the can_accept_op changes - I think it's quite clear now. I left one issue inline as well as a couple of nits & a question :)
grjte
approved these changes
May 23, 2022
There was a problem hiding this comment.
It looks good to me now!
Regarding #109 - should we update this issue to verify that procedure inlining is now happening optimallyl? I guess that would require checking that the old issue is resolved by this change (as it seems it should be) and that nothing new & unexpected pops up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks out several changes from #195 to make the PRs more manageable.
Major changes include:
SPANblock. Specifically, the assembler no longer insertsNOOPs to ensure proper alignment - this is now done at the processor level. This means that duplicateNOOPinsertion mentioned in Optimize the logic for inlining procedures #109 should no longer be an issue.PUSHoperation cannot be the last operation in an operation group (previously, it couldn't be the first operation).HALTprocessor instruction, though it doesn't do much yet.