Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking PR for v0.2 release #8

Merged
merged 790 commits into from
Aug 8, 2022
Merged

Tracking PR for v0.2 release #8

merged 790 commits into from
Aug 8, 2022

Conversation

bobbinth
Copy link
Contributor

@bobbinth bobbinth commented Nov 6, 2021

This PR will track progress of v0.2 release of Miden VM.

bobbinth and others added 29 commits June 18, 2022 12:54
docs(mdbook): update co-processor diagrams to show internal selectors
    - turn on keccak256_bit_interleaving & keccak256_2_to_1_hash tests
refactor(assembly): speed up script compilation
cargo fix

change string to str

fix comment

fixes

change analyze function return type to result

remove std

remove std

add comments
Add op batch flags to decoder trace
docs(mdbook): fix rendering issue of pow2 aux table
Implement construction of decoder aux column `p3`
remove redundant function

remove redundant function

fixes

docs(air): set first row address to 1

small fix

small fix

doc fixes
Add decoder constraint descriptions to mdbook
feat(air): add boundary constraint to hasher
Signed-off-by: Anjan Roy <hello@itzmeanjan.in>
bobbinth and others added 29 commits July 31, 2022 00:06
Refactor hash chiplet constants and chiplets trace tests module
Update design section in mdbook
Add hasher lookups to the chiplets bus
The auxiliary column `b_range` must always be one row longer than the main trace, in order to correctly verify range checks of the final value (u16::MAX). This is because the data used to generate the value included in the `b_range` column comes from the "current" row, but the value itself is included into the "next" row.

This was resolved by padding the main range checker trace with an extra row of the final value (u16::MAX). The 8-bit segment of the Range Checker's trace was adjusted accordingly with an additional lookup of ZERO (to account for the transition between the final two rows of the 16-bit segment of the trace where the value changes by 0).
Fix range checker auxiliary column trace
@bobbinth bobbinth merged commit e941cf8 into main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet