Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement running product column p0 in the range checker #230

Merged
merged 6 commits into from
Jun 3, 2022
Merged

Implement running product column p0 in the range checker #230

merged 6 commits into from
Jun 3, 2022

Conversation

grjte
Copy link
Contributor

@grjte grjte commented May 31, 2022

This PR adds handling of auxiliary trace segments to the ExecutionTrace and the ProcessorAir, and implements the range checker's first running product column p0 as described in the docs.

  • add range checker integration tests
  • refactor range checker constants
  • add auxiliary segment handling to the execution trace
  • implement the execution trace for the range checker's running product column p0
  • add constraint handling for auxiliary columns + constraints for running product column p0
  • add unit test for the execution trace of the range checker's running product column p0

@grjte grjte marked this pull request as ready for review May 31, 2022 15:04
@grjte grjte requested a review from bobbinth May 31, 2022 15:27
bobbinth
bobbinth requested changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I haven't reviewed the constraints part yet - but wanted to leave a few comments about the trace generation part for now.

air/src/lib.rs Outdated Show resolved Hide resolved
processor/src/trace/range/mod.rs Outdated Show resolved Hide resolved
processor/src/trace/range/mod.rs Outdated Show resolved Hide resolved
processor/src/trace/range/mod.rs Outdated Show resolved Hide resolved
processor/src/trace/range/mod.rs Outdated Show resolved Hide resolved
@grjte grjte requested a review from bobbinth June 2, 2022 16:03
bobbinth
bobbinth requested changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you! A few very small comments inline.

miden/tests/integration/air/range.rs Show resolved Hide resolved
processor/src/trace/range/mod.rs Show resolved Hide resolved
processor/src/trace/range/mod.rs Outdated Show resolved Hide resolved
air/src/range.rs Outdated Show resolved Hide resolved
air/src/lib.rs Outdated Show resolved Hide resolved
grjte added 6 commits June 3, 2022 09:17
@grjte
test: add air integration tests for the range checker
acaf170
@grjte
refactor: move range checker constants to core
29cca6b
@grjte
docs(mdbook): fix typo
aa685ff
@grjte
feat: build the aux trace with the range checker's p0 running product…
266f142 
… column

- Precompute the range-checker's flag values identified by the selector columns & save them as auxiliary column hints.
- Add auxiliary column hints to the execution trace handling.
- Add the execution trace for the auxiliary segment.
- Add the range checker's running p0 running product column execution trace
@grjte
feat(air): add auxiliary trace to ProcessorAir and range checker p0 c…
7498b12 
…onstraints

- Add handling of the assertions and transition constraints for auxiliary columns to the ProcessorAir.
- Add auxiliary column constraints for the range checker's p0 running product column.
@grjte
test: add unit test for the range checker p0 exec trace
336af62
@grjte grjte requested a review from bobbinth June 3, 2022 09:01
bobbinth
bobbinth approved these changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Thank you!

@bobbinth bobbinth merged commit 6c262ae into 0xPolygonMiden:next Jun 3, 2022
@bobbinth bobbinth mentioned this pull request Jun 10, 2022
Merged
39 tasks
@grjte grjte deleted the range-checker-p0 branch July 6, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grjte @bobbinth