Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add op batch flags to decoder trace #246

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Add op batch flags to decoder trace #246

merged 3 commits into from
Jun 21, 2022

Conversation

bobbinth
Copy link
Contributor

@bobbinth bobbinth commented Jun 14, 2022

This PR adds op batch flags to the decoder trace and makes a coupe of other small updates:

  • Add 3 op_batch_flag columns to the decoder trace.
  • Update the logic for how number of operation groups in the span is computed, and make related changes to trace generation.
  • Update the logic of how in_span flag is populated in the decoder trace.
  • Updated program hash computations to make them consistent between Script and execution trace.

@bobbinth bobbinth changed the base branch from main to next June 14, 2022 09:13
@bobbinth bobbinth marked this pull request as ready for review June 14, 2022 21:45
@bobbinth bobbinth requested a review from grjte June 14, 2022 21:45
@bobbinth bobbinth mentioned this pull request Jun 15, 2022
39 tasks
@bobbinth bobbinth force-pushed the decoder-trace2 branch 2 times, most recently from 257a42e to 84b0a16 Compare June 17, 2022 20:08
Copy link
Contributor

@grjte grjte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a few small things inline and one question about possibly unifying some span-related stuff to make it easier to keep track of how all the different things are related.

processor/src/decoder/mod.rs Outdated Show resolved Hide resolved
processor/src/lib.rs Outdated Show resolved Hide resolved
processor/src/lib.rs Outdated Show resolved Hide resolved
core/src/program/blocks/span_block.rs Outdated Show resolved Hide resolved
core/src/decoder/mod.rs Outdated Show resolved Hide resolved
@bobbinth bobbinth merged commit 923730f into next Jun 21, 2022
@bobbinth bobbinth deleted the decoder-trace2 branch June 21, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants