chore: update 0x deps #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimpers
changed the title
xianny
reviewed
Jun 23, 2021
test/sra_test.ts
Outdated
| reason: "should have required property 'baseToken'", | ||
| }, | ||
| { | ||
| field: 'quoteToken', // FIXME (xianny): bug in jsonschemas module |
There was a problem hiding this comment.
you can remove my comment since you removed the ugly instance. prefix!
xianny
approved these changes
Jun 23, 2021
|
thanks Kim, make sure you don't update |
kimpers
force-pushed
the
kim/feat/lido-deposit
branch
from
2dba33b
to
c75b4ca
Compare
kimpers
force-pushed
the
kim/feat/lido-deposit
branch
from
c75b4ca
to
d6985ec
Compare
kimpers
changed the title
|
deploy staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This bumps all
@0xdependencies to the latest version (which includes Lido support) and fixes issues arising from swapping to Ajv for json schemas.Depends on 0xProject/tools#38.
Testing Instructions
Checklist
Update documentation as needed. Website Documentation PR:
Prefix PR title with
[WIP]if necessary.Add tests to cover changes as needed.
Test changes on the staging environment with Matcha API Staging.
For more information see
0x API Matcha smoke test runbookin Quip.