Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return all json schema validation errors and expose Ajv types #38

Merged
merged 4 commits into from
Jun 28, 2021

Conversation

kimpers
Copy link
Contributor

@kimpers kimpers commented Jun 23, 2021

Description

By default Ajv only returns the first validation error, this fixes so that all errors are returned, and exposes the entire Ajv package under AJV to provide access to types etc.

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@kimpers kimpers force-pushed the kim/fix/json-schema-validation branch from dcd8f8e to dcdbffb Compare June 23, 2021 09:47
@kimpers kimpers force-pushed the kim/fix/json-schema-validation branch from dcdbffb to d5c7014 Compare June 23, 2021 09:53
@kimpers kimpers requested a review from xianny June 23, 2021 14:12
@kimpers kimpers force-pushed the kim/fix/json-schema-validation branch from 1dce5f6 to 1ee18c0 Compare June 23, 2021 15:43
xianny
xianny previously requested changes Jun 23, 2021
Copy link
Contributor

@xianny xianny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: let's also delete all the relayer_api_*.json schemas. We never updated them for V4 and now they are broken, I think it's a sign that they should live in 0x-api repo.

@kimpers kimpers force-pushed the kim/fix/json-schema-validation branch from 17e91d6 to a1f7019 Compare June 24, 2021 08:38
@kimpers kimpers dismissed xianny’s stale review June 24, 2021 08:58

resolved 👍

@kimpers kimpers merged commit f9e8674 into development Jun 28, 2021
@kimpers kimpers deleted the kim/fix/json-schema-validation branch June 28, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants